From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: vthiagar@codeaurora.org, Steve deRosier <derosier@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
steve.derosier@gmail.com
Subject: Re: [RFC 0/4] wireless: Per-sta NoAck and offload support
Date: Wed, 28 Mar 2018 09:37:26 +0200 [thread overview]
Message-ID: <5ABB4636.2040900@broadcom.com> (raw)
In-Reply-To: <94497d97976ff1934a08e70cc118bf56@codeaurora.org>
On 3/28/2018 8:09 AM, vthiagar@codeaurora.org wrote:
> On 2018-03-27 22:18, Steve deRosier wrote:
>> Hi Vasanthakumar,
>>
>> On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan
>> <vthiagar@codeaurora.org> wrote:
>>> Adds infrastructure for driver to offload NoAck functionality, driver
>>> like ath10k could make use of it. Also extends the current ndev wide
>>
>> I'm not really much of a fan of adding a feature without some use of
>> the feature. Perhaps if drivers "like" ath10k could use it, maybe you
>> should add a patch(s) to the series where one of those drivers
>> actually uses the feature. An API without an example of use is also
>> harder to evaluate effectively.
>
> I agree driver patch using the new NoAck infrastructure would help with
> understanding, ill post it once it is ready. But not sure the driver patch
> can be part of the same series.
The API patches would go in mac80211-next tree and indeed the driver
patch would go through wireless-drivers-next tree. However, an option
would be to add the driver patch(es) as RFC in the series so Johannes
can ignore it and we still have an example to look at.
Regards,
Arend
next prev parent reply other threads:[~2018-03-28 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 8:42 [RFC 0/4] wireless: Per-sta NoAck and offload support Vasanthakumar Thiagarajan
2018-03-27 8:42 ` [RFC 1/4] mac80211: Add NoAck policy functionality offload infrastructure Vasanthakumar Thiagarajan
2018-03-27 12:53 ` Johannes Berg
2018-03-28 5:35 ` vthiagar
2018-03-27 8:42 ` [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address Vasanthakumar Thiagarajan
2018-03-27 12:47 ` Johannes Berg
2018-03-28 4:54 ` vthiagar
2018-03-28 8:06 ` Johannes Berg
2018-03-28 8:50 ` vthiagar
2018-03-28 8:52 ` Johannes Berg
2018-03-27 8:42 ` [RFC 3/4] mac80211: Apply per-peer NoAck tid bitmap configuration Vasanthakumar Thiagarajan
2018-03-27 12:54 ` Johannes Berg
2018-03-28 5:43 ` vthiagar
2018-03-28 8:04 ` Johannes Berg
2018-03-29 5:31 ` vthiagar
2018-03-27 8:42 ` [RFC 4/4] mac80211: Advertise per-peer NoAck policy support Vasanthakumar Thiagarajan
2018-03-27 16:48 ` [RFC 0/4] wireless: Per-sta NoAck and offload support Steve deRosier
2018-03-28 6:09 ` vthiagar
2018-03-28 7:37 ` Arend van Spriel [this message]
2018-03-28 7:59 ` vthiagar
2018-03-28 8:03 ` Johannes Berg
2018-03-28 15:12 ` Steve deRosier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ABB4636.2040900@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=derosier@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=steve.derosier@gmail.com \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).