Linux wireless drivers development
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Johannes Berg" <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] cfg80211: release station info tidstats where needed
Date: Fri, 18 May 2018 12:25:06 +0200	[thread overview]
Message-ID: <5AFEAA02.2010303@broadcom.com> (raw)
In-Reply-To: <20180518094742.10669-2-johannes@sipsolutions.net>

On 5/18/2018 11:47 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This fixes memory leaks in cases where we got the station
> info but failed sending it out properly.

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   include/net/cfg80211.h | 13 +++++++++++++
>   net/wireless/nl80211.c | 11 ++++++++---
>   2 files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 8984d24d68b7..1c6364591856 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -5710,6 +5710,19 @@ void cfg80211_remain_on_channel_expired(struct wireless_dev *wdev, u64 cookie,
>    */
>   int cfg80211_sinfo_alloc_tid_stats(struct station_info *sinfo, gfp_t gfp);
>
> +/**
> + * cfg80211_sinfo_release_sinfo - release contents of station info

Maybe drop one '_sinfo' from the function name? Or 
cfg80211_sinfo_release_contents?

Regards,
Arend

  reply	other threads:[~2018-05-18 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  9:47 [PATCH 1/2] mac80211: allocate and fill tidstats only when needed Johannes Berg
2018-05-18  9:47 ` [PATCH 2/2] cfg80211: release station info tidstats where needed Johannes Berg
2018-05-18 10:25   ` Arend van Spriel [this message]
2018-05-18 10:37     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AFEAA02.2010303@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox