From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Denis Kenzior <denkenz@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Andrew Zaborowski <andrew.zaborowski@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner
Date: Tue, 22 May 2018 12:39:01 +0200 [thread overview]
Message-ID: <5B03F345.70809@broadcom.com> (raw)
In-Reply-To: <A996D5EE-1279-4DEC-832F-FC4D5FD7FC61@gmail.com>
On 5/8/2018 5:05 PM, Denis Kenzior wrote:
> Hi Arend,
>
>>
>> Sure. I guess we all have been there kicking of wpa_s and discovering
>> there is already one running in the background. I am just a bit
>> squeamish to change the behavior like this. Hmmmm. Is wpa_s already
>> using SOCKET_OWNER. If so, I might create a patch to opt-out for that
>> so people can knowingly choose chaos ;-)
>>
>
> wpa_s is using SOCKET_OWNER these days. However, with the introduction
> of Control Port over NL80211, just getting rid of SOCKET_OWNER might not
> be that easy.
I have a regression test script employing py80211 which listens for
connect event. Right now I am using an older wpa_s, but the above will
screw it up.
If I recall correctly the mlme notification needed to be unicast,
because multicast was not 100% reliable, right? Would it be acceptable
to send unicast to the socket owner and still do the multicast or are we
already doing that? If not, that would fix my imminent issue.
Regards,
Arend
next prev parent reply other threads:[~2018-05-22 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 1:47 [PATCH] nl80211: Reject disconnect commands except from conn_owner Andrew Zaborowski
2018-04-28 13:07 ` Kalle Valo
2018-04-29 18:30 ` Andrew Zaborowski
2018-05-07 19:19 ` Johannes Berg
2018-05-08 12:18 ` Arend van Spriel
2018-05-08 12:19 ` Johannes Berg
2018-05-08 12:34 ` Arend van Spriel
[not found] ` <A996D5EE-1279-4DEC-832F-FC4D5FD7FC61@gmail.com>
2018-05-22 10:39 ` Arend van Spriel [this message]
2018-05-22 14:45 ` Denis Kenzior
2018-05-08 20:03 ` Andrew Zaborowski
-- strict thread matches above, loose matches on Subject: below --
2018-05-22 0:46 Andrew Zaborowski
2018-05-22 7:53 ` Arend van Spriel
2018-05-22 8:21 ` Johannes Berg
2018-05-22 10:30 ` Arend van Spriel
2018-05-22 10:33 ` Andrew Zaborowski
2018-05-22 10:39 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B03F345.70809@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=andrew.zaborowski@intel.com \
--cc=denkenz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).