From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/6] brcmfmac: fallback mechanism to determine monitor mode features
Date: Mon, 25 Jun 2018 10:21:09 +0200 [thread overview]
Message-ID: <5B30A5F5.9080404@broadcom.com> (raw)
In-Reply-To: <CACna6rxi88e6oek8zt_7KG6PY4ih_ehpsd67hK2DXGHKQZhSSg@mail.gmail.com>
On 6/24/2018 4:08 PM, Rafał Miłecki wrote:
> On Fri, 22 Jun 2018 at 20:45, Arend van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>> Firmwares may not provide all monitor mode features in the "cap" iovar.
>> For those this fallback mechanism uses "sta_monitor" iovar. If firmware
>> is compiled with stamon, this iovar will fail with BCME_NOTUP; Otherwise
>> it fails with BCME_UNSUPPORTED.
>
> It's probably not the first time ever, but it appears your research
> (theory) doesn't match my experience (practice) ;) I'm afraid you
> missed some important check when analyzing firmware code.
It was not all theory ;-) but apparently I did not cover all bases. I
only checked with 4366c0 (actually with 43664 aka 4366E) on the release
branch I am working on.
> I've just tested all firmwares I got (for 43602a1, 4366b1 and 4366c0)
> and all of them return -4 (BCME_NOTUP) for "sta_monitor" when
> firmware/interface is down. It appears this test requires bringing
> firmware/interface up to make it reliable. Apparently even firmwares
> *without* sta_monitor return -4 (BCME_NOTUP) when firmware/interface
> is down.
That is crap. So back to the drawing board. Thanks for keeping the taps
on this.
Regards,
Arend
next prev parent reply other threads:[~2018-06-25 8:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 18:43 [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Arend van Spriel
2018-06-22 18:43 ` [PATCH 1/6] brcmfmac: remove fallback mechanism for BRCMF_FEAT_MONITOR Arend van Spriel
2018-06-29 6:55 ` [1/6] " Kalle Valo
2018-06-22 18:43 ` [PATCH 2/6] brcmfmac: rename BRCMF_FEAT_MONITOR_FMT_RADIOTAP to BRCMF_FEAT_RADIOTAP Arend van Spriel
2018-06-22 18:43 ` [PATCH 3/6] brcmfmac: fix for proper support of 160MHz bandwidth Arend van Spriel
2018-06-22 18:43 ` [PATCH 4/6] brcmfmac: increase buffer for obtaining firmware capabilities Arend van Spriel
2018-06-22 18:43 ` [PATCH 5/6] brcmfmac: add new feature flags for monitor mode operation Arend van Spriel
2018-06-22 18:43 ` [PATCH 6/6] brcmfmac: fallback mechanism to determine monitor mode features Arend van Spriel
2018-06-24 14:08 ` Rafał Miłecki
2018-06-25 8:21 ` Arend van Spriel [this message]
2018-06-24 11:48 ` [PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode Rafał Miłecki
2018-06-25 4:40 ` Rafał Miłecki
2018-06-25 8:31 ` Arend van Spriel
2018-06-25 8:43 ` Rafał Miłecki
2018-06-29 6:58 ` Kalle Valo
2018-08-29 20:17 ` Rafał Miłecki
2018-09-05 11:06 ` Arend van Spriel
2018-09-05 13:51 ` Rafał Miłecki
2018-06-25 8:18 ` Arend van Spriel
2018-06-25 8:43 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B30A5F5.9080404@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).