linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Sven Eckelmann <sven.eckelmann@openmesh.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit
Date: Mon, 30 Jul 2018 20:50:16 +0200	[thread overview]
Message-ID: <5B5F5DE8.9060101@broadcom.com> (raw)
In-Reply-To: <20180730153933.3771-1-sven.eckelmann@openmesh.com>

+ Rafał

On 7/30/2018 5:39 PM, Sven Eckelmann wrote:
> Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in
> the RX and TX path. These filtered channel can in theory still be used by
> the hardware but the signal strength is reduced so much that it makes no
> sense.
>
> There is already a DT property to limit the available channels but ath10k
> has to manually call this functionality to limit the currrently set wiphy
> channels further.

Wondering whether we can call it in wiphy_register() like below. Not 
sure why we did not explore that with the introduction of it by Rafał. 
Maybe he remembers. I did not find something in that direction in 
patchwork, but may have missed it. I know mt76 drops the band reference 
if it ends up with all channels disabled. Maybe that was the reason.

Regards,
Arend
---
diff --git a/net/wireless/core.c b/net/wireless/core.c
index a88551f..2e00cb1 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -742,6 +742,8 @@ int wiphy_register(struct wiphy *wiphy)
	if (res)
		return res;

+	wiphy_read_of_freq_limits(wiphy);
+
	/* sanity check supported bands/channels */
	for (band = 0; band < NUM_NL80211_BANDS; band++) {
		u16 types = 0;

  reply	other threads:[~2018-07-30 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 15:39 [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit Sven Eckelmann
2018-07-30 18:50 ` Arend van Spriel [this message]
2018-08-24 11:46   ` Kalle Valo
2018-07-30 18:54 ` Arend van Spriel
2018-07-30 18:56   ` Arend van Spriel
2018-08-28 13:51 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B5F5DE8.9060101@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sven.eckelmann@openmesh.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).