From: zhong jiang <zhongjiang@huawei.com>
To: Pkshih <pkshih@realtek.com>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'
Date: Tue, 23 Oct 2018 16:23:19 +0800 [thread overview]
Message-ID: <5BCEDA77.9010505@huawei.com> (raw)
In-Reply-To: <1540281873.25715.2.camel@realtek.com>
On 2018/10/23 16:05, Pkshih wrote:
> On Tue, 2018-10-23 at 13:47 +0800, zhong jiang wrote:
>> 'radiob_array_table' and 'radiob_arraylen' is not used after setting its
>> value.
>> It is safe to remove the unused variable.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> index 5cf29f5..3f33278 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct
>> ieee80211_hw *hw,
>> int i;
>> bool rtstatus = true;
>> u32 *radioa_array_table;
>> - u32 *radiob_array_table;
>> - u16 radioa_arraylen, radiob_arraylen;
>> + u16 radioa_arraylen;
>>
>> radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>> radioa_array_table = RTL8723E_RADIOA_1TARRAY;
>> - radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
>> - radiob_array_table = RTL8723E_RADIOB_1TARRAY;
>>
>> rtstatus = true;
>>
> I think 8723ae has only one antenna, so you can remove radio B array as well.
>
Yep, Will do.
Thanks,
zhong jiang
prev parent reply other threads:[~2018-10-23 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 5:47 [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' zhong jiang
2018-10-23 8:05 ` Pkshih
2018-10-23 8:23 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BCEDA77.9010505@huawei.com \
--to=zhongjiang@huawei.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).