From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Fix setting txpower to zero.
Date: Fri, 07 Feb 2020 09:55:36 -0800 [thread overview]
Message-ID: <5E3DA498.20505@candelatech.com> (raw)
In-Reply-To: <27b64bd26e7d8c13d22a3a9b950eb3db16b630a2.camel@sipsolutions.net>
On 02/07/2020 04:03 AM, Johannes Berg wrote:
> On Tue, 2019-12-17 at 10:30 -0800, greearb@candelatech.com wrote:
>>
>> drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
>> drivers/net/wireless/ath/ath9k/main.c | 3 +++
>> drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
>
> All these driver changes worry me a bit - wouldn't that affect other
> drivers as well?
>
> johannes
>
The goal was to NOT adversely affect the drivers when the default (not-set)
value changed.
I changed the name of the variable and then touched every driver that used it
as a way of making sure that I found everything in the tree.
Hopefully that found everything... I did not specifically test ath9k, only ath10k
driver with this change.
(I then changed the variable name back before submitting the patch).
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2020-02-07 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 18:30 [PATCH v2] mac80211: Fix setting txpower to zero greearb
2020-02-07 12:03 ` Johannes Berg
2020-02-07 17:55 ` Ben Greear [this message]
2020-02-07 19:19 ` Johannes Berg
2020-02-07 20:23 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E3DA498.20505@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).