From: Benjamin Li <benl@squareup.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy rates
Date: Wed, 3 Nov 2021 10:01:13 -0700 [thread overview]
Message-ID: <5a74137a-97ee-711d-97a2-105b0dd92cee@squareup.com> (raw)
In-Reply-To: <CAMZdPi8c1aJCCL8b6iYSz1Ev46jK15Fpa9pG-2FGhrT3FR2RMA@mail.gmail.com>
On 11/3/21 10:08 AM, Loic Poulain wrote:
> Hi Ben,
>
> It looks fine, but can you replace it with a 'status.rate_idx >= 4'.
> I get sporadic 5Ghz frames reported with rate_idx=0 (firmware miss?),
> leading to warnings because status.rate_idx is -4(unsigned) in that
> case. So better to report a wrong rate than a corrupted one.
>
Thanks for confirming that. Will send v3 that just falls-through on
rate_idx < 4, no warn or log.
Ben
>
>
> Regards,
> Loic
>
prev parent reply other threads:[~2021-11-03 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 15:55 [PATCH v2 0/2] wcn36xx: populate band before determining rate on RX Benjamin Li
2021-11-03 15:55 ` [PATCH v2 1/2] " Benjamin Li
2021-11-03 15:55 ` [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy rates Benjamin Li
2021-11-03 17:08 ` Loic Poulain
2021-11-03 17:01 ` Benjamin Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a74137a-97ee-711d-97a2-105b0dd92cee@squareup.com \
--to=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox