From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2DDC25B08 for ; Wed, 17 Aug 2022 08:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232227AbiHQIaw (ORCPT ); Wed, 17 Aug 2022 04:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiHQIau (ORCPT ); Wed, 17 Aug 2022 04:30:50 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5866B7C766 for ; Wed, 17 Aug 2022 01:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=pUXMUJa82Y4IMLdzC18iKA2e80pkPuOgUxS/S3ws7QQ=; t=1660725048; x=1661934648; b=UJvVUAFScSCwwhat/wV2fRdQirLD+DMxkuoZ1YNUgX+9fBG hNrRfUyp5HsuR9sNeGjPB+zDWubQpOv2RhZlCxo8OevePj6JlE3OjyBXOU3XXLeYMD639B5cItgTB 9+Qf+bTn/mNQZtM5W92SyAXiIj98dwyj7tHoX1mL6i3zitOSBkDK//Dxv4VZzlum0VmAkBlNW7CmO MTOaGIHtV39Y4nLFNEVoGF7Dn1AlStPfjqRlFRfx8kMXg3KLQPhH8N+Bzi2pLANXOy9kbImsQ6w8h JbIyEv/fT4sJ5WcjhS+6mTGMzA+n+34aYxbcHZTZrAnkGa2YcWfzCvMfV/e1C7tw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oOERb-00AIBn-2i; Wed, 17 Aug 2022 10:30:32 +0200 Message-ID: <5b24421363048bff1a9f03174cb0223b3e226bf9.camel@sipsolutions.net> Subject: Re: [PATCH 1/9] wifi: mac80211: allow enabling chanctx until hw registration From: Johannes Berg To: Sean Wang Cc: Sean Wang =?UTF-8?Q?=28=E7=8E=8B=E5=BF=97=E4=BA=98=29?= , Felix Fietkau , lorenzo.bianconi@redhat.com, Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, jenhao.yang@mediatek.com, robin.chiu@mediatek.com, Eddie.Chen@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com, Stella.Chang@mediatek.com, Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com, kuabhs@google.com, druth@google.com, abhishekpandit@google.com, shawnku@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Wed, 17 Aug 2022 10:30:30 +0200 In-Reply-To: References: <473fc7b169f288b7815a7736cf33ac0ec1599a09.1660606893.git.objelf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2022-08-17 at 01:28 -0700, Sean Wang wrote: > Based on mt76 driver logic, alloc_hw would be needed before loading firmw= are > because alloc_hw creates an instance of "struct mt76_dev*" the > firmware loading relies on, > and so the firmware capabilities cannot be decided before we alloc_hw > in mt76 driver. >=20 I don't really see why you couldn't change that though? There's no fundamental reason you need to load the firmware before registering with mac80211? And fundamentally, I'm not even sure how you are achieving a change of the ops - you're meant to point those to a *const* ops, so you need two versions of the ops, one with and one without chanctx, and point to the correct one at allocation ... johannes