From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC 04/12] ath10k: htc: refactorization
Date: Thu, 17 Nov 2016 17:32:17 +0100 [thread overview]
Message-ID: <5b62d41b-7125-f1ce-b09f-29db7572a748@gmail.com> (raw)
In-Reply-To: <CA+BoTQnTkwQjmNBdr8a+YauXffWGNBNyPTZ=RByoviTSp+1ZYQ@mail.gmail.com>
On 11/15/2016 11:19 AM, Michal Kazior wrote:
> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wrote:
>> Code refactorization:
>>
>> Moved the code for ep 0 in ath10k_htc_rx_completion_handler
>> to ath10k_htc_control_rx_complete.
>>
>> This eases the implementation of SDIO/mbox significantly since
>> the ep_rx_complete cb is invoked directly from the SDIO/mbox
>> hif layer.
>>
>> Since the ath10k_htc_control_rx_complete already is present
>> (only containing a warning message) there is no reason for not
>> using it (instead of having a special case for ep 0 in
>> ath10k_htc_rx_completion_handler).
>
> This should be squashed with Patch 3 since it's inseparable part of
> the same refactorization.
>
>
> Michał
>
Hmm, I don't really see why this is an inseparable part of the previous
patch.
As far as I see this patch has nothing to do with patch 3, or am I
missing anything?
Are you really sure they should be squashed?
Erik
next prev parent reply other threads:[~2016-11-17 17:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 16:33 [RFC 00/12] ath10k sdio support Erik Stromdahl
2016-11-14 16:33 ` [RFC 01/12] ath10k: htc: made static function public Erik Stromdahl
2016-11-14 16:33 ` [RFC 02/12] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2016-11-15 9:57 ` Michal Kazior
2016-11-15 17:31 ` Erik Stromdahl
2016-11-16 13:53 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 03/12] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl
2016-11-15 10:13 ` Michal Kazior
2016-11-15 17:07 ` Erik Stromdahl
2016-11-16 14:29 ` Michal Kazior
2016-11-14 16:33 ` [RFC 04/12] ath10k: htc: refactorization Erik Stromdahl
2016-11-15 10:19 ` Michal Kazior
2016-11-17 16:32 ` Erik Stromdahl [this message]
2016-11-18 14:49 ` Michal Kazior
2016-11-14 16:33 ` [RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl
2016-11-15 10:25 ` Michal Kazior
2016-11-15 10:46 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Erik Stromdahl
2016-11-15 10:28 ` Michal Kazior
2016-11-15 17:11 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 07/12] ath10k: Added SDIO dbg masks Erik Stromdahl
2016-11-14 16:33 ` [RFC 08/12] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl
2016-11-14 16:33 ` [RFC 09/12] ath10k: Mailbox address definitions Erik Stromdahl
2016-11-15 10:31 ` Michal Kazior
2016-11-15 10:48 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 10/12] ath10k: Added QCA65XX hw definition Erik Stromdahl
2016-11-15 10:34 ` Michal Kazior
2016-11-15 10:54 ` Valo, Kalle
2016-11-15 18:34 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 11/12] ath10k: Added more host_interest members Erik Stromdahl
2016-11-14 16:33 ` [RFC 12/12] ath10k: Added sdio support Erik Stromdahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b62d41b-7125-f1ce-b09f-29db7572a748@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).