From: Ping-Ke Shih <pkshih@realtek.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal
Date: Mon, 23 Oct 2023 02:35:33 +0000 [thread overview]
Message-ID: <5b9ea29daaaa4ebb8bc75cd384aaee80@realtek.com> (raw)
In-Reply-To: <20231022163628.111991-1-dmantipov@yandex.ru>
> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Monday, October 23, 2023 12:36 AM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru>
> Subject: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal
>
> Remove unused and set but otherwise unused 'bbrf_ready', 'external_pa',
> 'pa_mode', 'rx_tag', 'rts_en', 'wow_enable', 'wow_enabled' and
> 'hw_rof_enable' (which seems to be an erroneous duplication of the same
> one of 'struct rtl_phy') fields of 'struct rtl_hal', adjust related
> code.
Why not removing 'hw_rof_enable' from 'struct rtl_phy'? Then, this patch can
be _purely_ cleanup unused code.
Ping-Ke
next prev parent reply other threads:[~2023-10-23 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 16:36 [PATCH] wifi: rtlwifi: cleanup struct rtl_hal Dmitry Antipov
2023-10-23 2:35 ` Ping-Ke Shih [this message]
2023-10-23 9:17 ` [PATCH 1/3] [v2] " Dmitry Antipov
2023-10-23 9:17 ` [PATCH 2/3] [v2] wifi: rtlwifi: cleanup struct rtl_phy Dmitry Antipov
2023-10-24 1:56 ` Ping-Ke Shih
2023-10-23 9:17 ` [PATCH 3/3] [v2] wifi: rtlwifi: typo fix Dmitry Antipov
2023-10-24 1:59 ` Ping-Ke Shih
2023-10-24 1:55 ` [PATCH 1/3] [v2] wifi: rtlwifi: cleanup struct rtl_hal Ping-Ke Shih
2023-10-30 17:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9ea29daaaa4ebb8bc75cd384aaee80@realtek.com \
--to=pkshih@realtek.com \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).