From: Johannes Berg <johannes@sipsolutions.net>
To: Kang Yang <quic_kangyang@quicinc.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] wifi: ath11k: add P2P IE in beacon template
Date: Tue, 27 Feb 2024 08:32:48 +0100 [thread overview]
Message-ID: <5c5ad99d3c2f3b9915b440057eab6618639cd31f.camel@sipsolutions.net> (raw)
In-Reply-To: <b20fc717-654d-4e64-920f-699fe3ec5598@quicinc.com>
On Tue, 2024-02-27 at 14:58 +0800, Kang Yang wrote:
>
> > > + if (arvif->vif->type != NL80211_IFTYPE_AP || !arvif->vif->p2p)
> >
> > this logic isn't applicable for NL80211_IFTYPE_P2P_GO ?
>
> The original intention here is to determine if it is P2P GO, if yes,
> continue, otherwise return.
>
>
> Maybe this judgment is a bit misleading, let me replace with
> if (arvif->vdev_subtype != WMI_VDEV_SUBTYPE_P2P_GO) ?
There's also
ieee80211_vif_type_p2p(arvif->vif) != NL80211_IFTYPE_P2P_GO
if you wanted to write it that way.
@Jeff: NL80211_IFTYPE_P2P_GO is not used by mac80211 internally, it
translates that to vif->type==NL80211_IFTYPE_AP && vif->p2p==true.
johannes
next prev parent reply other threads:[~2024-02-27 7:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 6:01 [PATCH 0/6] wifi: ath11k: P2P support for QCA6390/WCN6855/QCA2066 Kang Yang
2024-02-26 6:01 ` [PATCH 1/6] wifi: ath11k: change interface combination for P2P mode Kang Yang
2024-02-26 18:53 ` Jeff Johnson
2024-02-26 6:01 ` [PATCH 2/6] wifi: ath11k: add P2P IE in beacon template Kang Yang
2024-02-26 19:05 ` Jeff Johnson
2024-02-27 6:58 ` Kang Yang
2024-02-27 7:32 ` Johannes Berg [this message]
2024-02-27 15:05 ` Jeff Johnson
2024-02-27 15:11 ` Johannes Berg
2024-02-26 19:54 ` Jeff Johnson
2024-02-26 6:02 ` [PATCH 3/6] wifi: ath11k: implement handling of P2P NoA event Kang Yang
2024-02-26 19:53 ` Jeff Johnson
2024-02-26 20:59 ` Jeff Johnson
2024-02-27 3:16 ` Kang Yang
2024-02-27 11:35 ` Kang Yang
2024-02-26 6:02 ` [PATCH 4/6] wifi: ath11k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512 Kang Yang
2024-02-26 19:54 ` Jeff Johnson
2024-02-26 6:02 ` [PATCH 5/6] wifi: ath11k: invert scan flag WMI_SCAN_FILTER_PROBE_REQ for QCA6390/WCN6855/QCA2066 Kang Yang
2024-02-26 20:40 ` Jeff Johnson
2024-02-27 3:15 ` Kang Yang
2024-02-26 6:02 ` [PATCH 6/6] wifi: ath11k: advertise P2P dev support " Kang Yang
2024-02-26 20:41 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c5ad99d3c2f3b9915b440057eab6618639cd31f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_kangyang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox