From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Should we check netif_running in cfg80211_calculate_bi_data?
Date: Tue, 23 Oct 2018 21:53:08 +0200 [thread overview]
Message-ID: <5d6d273615166550749ae68b6eb2ab37f8265b06.camel@sipsolutions.net> (raw)
In-Reply-To: <5e048867-0294-4218-6b2b-bcbcad5be763@candelatech.com>
On Tue, 2018-10-23 at 12:19 -0700, Ben Greear wrote:
>
> Oct 23 12:11:05 ben-ota-2.candelatech.com kernel: Assigning beacon-in-gcd to: 240 from wdev: vap39
> Oct 23 12:11:05 ben-ota-2.candelatech.com kernel: beacon-int-diff, beacon-int-gcd: 240 new-beacon-int: 100
This new-beacon-int 100 seems strange and suspicious. Why is it even
trying to look at this? Hmm.
> Maybe we need to clear beacon-interval back to 0 on admin down of the wifi dev?
We should be doing this, we should end up in __cfg80211_stop_ap() and
that does clear it? Hmm... perhaps this _fails_ somehow, and we don't
clear it in the error path? I suppose we really should make that
unconditional because there's nothing we can do to recover from that
error ...
johannes
next prev parent reply other threads:[~2018-10-23 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 20:27 Should we check netif_running in cfg80211_calculate_bi_data? Ben Greear
2018-10-23 9:32 ` Johannes Berg
2018-10-23 19:19 ` Ben Greear
2018-10-23 19:53 ` Johannes Berg [this message]
2018-10-23 20:22 ` Ben Greear
2018-10-23 20:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6d273615166550749ae68b6eb2ab37f8265b06.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox