From: Yibo Zhao <yiboz@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH V3 2/4] mac80211: defer txqs removal from rbtree
Date: Tue, 24 Sep 2019 10:55:42 +0800 [thread overview]
Message-ID: <5dadc4a130c2ba3d6548969f47c5f85c@codeaurora.org> (raw)
In-Reply-To: <87ef075lit.fsf@toke.dk>
On 2019-09-23 18:56, Toke Høiland-Jørgensen wrote:
> Yibo Zhao <yiboz@codeaurora.org> writes:
>
>> In a loop txqs dequeue scenario, if the first txq in the rbtree gets
>> removed from rbtree immediately in the ieee80211_return_txq(), the
>> loop will break soon in the ieee80211_next_txq() due to schedule_pos
>> not leading to the second txq in the rbtree. Thus, defering the
>> removal right before the end of this schedule round.
>
> Didn't we agree that we could fix this by making __unschedule_txq()
> aware of schedule_pos instead of this deferred removal mechanism?
Yes, V3 is actually used to update the commit log of [PATCH V3 3/4] so
that we can discuss in parallel with others, and [PATCH V3 4/4] for
discussion. Please ignore [PATCH V3 2/4]. we can keep our discussion in
V2 until we conclude the final one and then a new version will be sent
out along with [mac80211: Switch to a virtual time-based airtime
scheduler] which includes the reducing lock fix.
Sorry for the confusion, ;).
>
> -Toke
--
Yibo
next prev parent reply other threads:[~2019-09-24 2:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 7:19 [PATCH V3 0/4] Enable virtual time-based airtime scheduler support on ath10k Yibo Zhao
2019-09-23 7:19 ` [PATCH V3 1/4] mac80211: Switch to a virtual time-based airtime scheduler Yibo Zhao
2019-09-23 7:19 ` [PATCH V3 2/4] mac80211: defer txqs removal from rbtree Yibo Zhao
2019-09-23 10:56 ` Toke Høiland-Jørgensen
2019-09-24 2:55 ` Yibo Zhao [this message]
2019-09-23 7:20 ` [PATCH V3 3/4] mac80211: fix low throughput in multi-clients situation Yibo Zhao
2019-09-23 10:55 ` Toke Høiland-Jørgensen
2019-09-24 8:22 ` Yibo Zhao
2019-09-24 8:48 ` Toke Høiland-Jørgensen
2019-09-24 8:58 ` Yibo Zhao
2019-09-23 7:20 ` [PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together Yibo Zhao
2019-09-23 11:00 ` Toke Høiland-Jørgensen
2019-09-24 3:19 ` Yibo Zhao
2019-09-24 7:27 ` Toke Høiland-Jørgensen
2019-10-01 10:19 ` [PATCH V3 0/4] Enable virtual time-based airtime scheduler support on ath10k Johannes Berg
2019-10-01 10:59 ` Yibo Zhao
2019-10-01 11:05 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dadc4a130c2ba3d6548969f47c5f85c@codeaurora.org \
--to=yiboz@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).