From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
Andrea Merello <andrea.merello@gmail.com>,
Taehee Yoo <ap420073@gmail.com>
Subject: RE: [PATCH v3 1/5] wifi: rtl8xxxu: Deduplicate the efuse dumping code
Date: Tue, 20 Dec 2022 05:59:08 +0000 [thread overview]
Message-ID: <5e6186b8158d4a22a5d838324eb63760@realtek.com> (raw)
In-Reply-To: <2aa5200a-ee42-e064-16a1-672bed5708c6@gmail.com>
> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Saturday, December 17, 2022 10:12 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>; Andrea Merello
> <andrea.merello@gmail.com>; Taehee Yoo <ap420073@gmail.com>
> Subject: [PATCH v3 1/5] wifi: rtl8xxxu: Deduplicate the efuse dumping code
>
> Every chip family except RTL8723AU has a copy of the efuse dumping
> code. Remove this and dump the efuse from a single place using a new
> function rtl8xxxu_dump_efuse().
>
> Also, use print_hex_dump() to print the efuse instead of a loop and
> dev_info(). It shows the ASCII interpretation of the bytes, which is
> nice.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> v3:
> - Implement suggestion from Ping-Ke Shih:
> - Use EFUSE_MAP_LEN instead of EFUSE_REAL_CONTENT_LEN_8723A.
> They have the same value.
>
> v2:
> - Patch is new in v2.
> ---
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 11 -----------
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c | 10 ----------
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 9 ---------
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 11 -----------
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 13 +++++++++++++
> 5 files changed, 13 insertions(+), 41 deletions(-)
>
[...]
next prev parent reply other threads:[~2022-12-20 5:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 14:12 [PATCH v3 1/5] wifi: rtl8xxxu: Deduplicate the efuse dumping code Bitterblue Smith
2022-12-17 14:13 ` [PATCH v3 2/5] wifi: rtl8xxxu: Make rtl8xxxu_load_firmware take const char* Bitterblue Smith
2022-12-20 5:59 ` Ping-Ke Shih
2022-12-17 14:15 ` [PATCH v3 3/5] wifi: rtl8xxxu: Define masks for cck_agc_rpt bits Bitterblue Smith
2022-12-20 5:59 ` Ping-Ke Shih
2022-12-17 14:18 ` [PATCH v3 4/5] wifi: rtl8xxxu: Support new chip RTL8188EU Bitterblue Smith
2022-12-20 6:00 ` Ping-Ke Shih
2022-12-17 14:21 ` [PATCH v3 5/5] wifi: rtl8xxxu: Add rate control code for RTL8188EU Bitterblue Smith
2022-12-20 6:00 ` Ping-Ke Shih
2022-12-20 5:59 ` Ping-Ke Shih [this message]
2022-12-21 18:51 ` [PATCH v3 1/5] wifi: rtl8xxxu: Deduplicate the efuse dumping code Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e6186b8158d4a22a5d838324eb63760@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=andrea.merello@gmail.com \
--cc=ap420073@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).