From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dhyan K Prajapati <dhyan19022009@gmail.com>,
Lachlan Hodges <lachlan.hodges@morsemicro.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Dhyan K Prajapati <dhyan1902209@gmail.com>
Subject: Re: [PATCH wireless] wifi: mac80211: skip BSS_CHANGED_TXPOWER for monitor interfaces
Date: Sat, 7 Feb 2026 12:06:27 +0100 [thread overview]
Message-ID: <5f3b8417-b1be-4dbf-9de1-cd29b8b39f6e@kernel.org> (raw)
In-Reply-To: <20260207110224.32755-1-dhyan19022009@gmail.com>
On 07/02/2026 12:02, Dhyan K Prajapati wrote:
> Monitor mode interfaces do not maintain a BSS context, since a commit in
> July 2025 monitor interfaces with WANT_MONITOR_VIF began receiving link
> change notification duing ieee80211_add_vitual_monitor(), when
> ieee_assign_link_chanctx() assigns a channel context, it triggers
> ieee80211_recalc_txpower() this sends a bss_info_changed callback
> receive link->conf as the bss_conf prameter, in monitor mode it isn't
> initialised leading to NULL pointer dereference in drivers like iwldvm,
> as BSS_CHANGED_TXPOWER is not applicable for monitor mode we can just
Impossible to understand.
> skip it.
>
> Fixes: c57e5b9819df ("wifi: mac80211: fix WARN_ON for monitor mode on some devices")
> Tested-by: Dhyan K Prajapati <dhyan1902209@gmail.com>
No, you are the same person.
Plus I do not believe that this is anything more than microslop AI.
You ignore people's feedback, do not respond to it, do not version your
patches (still!). Start reading and responding the feedback. Provide
proofs (e.g. by improving your contributions) that you actually read
what we asked.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-02-07 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 11:02 [PATCH wireless] wifi: mac80211: skip BSS_CHANGED_TXPOWER for monitor interfaces Dhyan K Prajapati
2026-02-07 11:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f3b8417-b1be-4dbf-9de1-cd29b8b39f6e@kernel.org \
--to=krzk@kernel.org \
--cc=dhyan19022009@gmail.com \
--cc=dhyan1902209@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=lachlan.hodges@morsemicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox