From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B199C433EF for ; Sun, 16 Jan 2022 17:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbiAPRzl (ORCPT ); Sun, 16 Jan 2022 12:55:41 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:42210 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230174AbiAPRzl (ORCPT ); Sun, 16 Jan 2022 12:55:41 -0500 X-UUID: f68374cc18eb4596a787a7c59d07d1cf-20220117 X-UUID: f68374cc18eb4596a787a7c59d07d1cf-20220117 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 232353742; Mon, 17 Jan 2022 01:55:39 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 17 Jan 2022 01:55:38 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 17 Jan 2022 01:55:38 +0800 Message-ID: <5fdb8db1f02ffdacd554b7db531cf7719399cbdd.camel@mediatek.com> Subject: Re: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module From: Ryder Lee To: Lorenzo Bianconi , CC: , , Date: Mon, 17 Jan 2022 01:55:38 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, 2022-01-16 at 13:43 +0100, Lorenzo Bianconi wrote: > Move HE radiotap parsing code in mt76-connac module since it is > shared > between mt7921 and mt7915 drivers. > > Signed-off-by: Lorenzo Bianconi > --- > .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + > .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ > .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + > .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +--------------- > - [...] > +mt76_connac_mac_decode_he_mu_radiotap(struct sk_buff *skb, __le32 > *rxv) > +{ > + struct mt76_rx_status *status = (struct mt76_rx_status *)skb- > >cb; > + static const struct ieee80211_radiotap_he_mu mu_known = { > + .flags1 = HE_BITS(MU_FLAGS1_SIG_B_MCS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_DCM_KNOWN) | > + HE_BITS(MU_FLAGS1_CH1_RU_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_COMP_KNOWN), > + .flags2 = HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) | > + HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN), I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here. Ryder