public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Subject: iwlmld iwl_mld_change_vif_links can return un-initilized 'err'
Date: Sat, 14 Feb 2026 09:11:43 -0800	[thread overview]
Message-ID: <5ffe48af-e02d-4d02-b669-6a9d6797b956@candelatech.com> (raw)

Hello,

I believe this method:

static int
iwl_mld_change_vif_links(struct ieee80211_hw *hw,

Can return un-initialized 'err' in case that this return path is taken:

	if (WARN_ON(!iwl_mld_error_before_recovery(mld)))
		return err;

I saw this warning hit, and then later kernel crashed with some debugfs
dentry being bogus, but not sure that is actually related.

Probably err should be initialized to -EINVAL at top of the method.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

             reply	other threads:[~2026-02-14 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14 17:11 Ben Greear [this message]
2026-02-14 17:15 ` iwlmld iwl_mld_change_vif_links can return un-initilized 'err' Ben Greear
2026-02-15  4:29   ` Korenblit, Miriam Rachel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ffe48af-e02d-4d02-b669-6a9d6797b956@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox