From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: add PM hooks
Date: Mon, 4 Aug 2008 18:27:23 +0200 [thread overview]
Message-ID: <6064CD72-8B4A-4F23-BCFA-4D656729E60D@holtmann.org> (raw)
In-Reply-To: <1217866765.1299.9.camel@johannes.berg>
Hi Johannes,
>>> + .suspend = wiphy_suspend,
>>> + .resume = wiphy_resume,
>>> };
>>
>> this needs to be wrapped into CONFIG_PM, because otherwise the build
>> will fail when CONFIG_PM is not enabled.
>
> I thought so too, but then I looked at include/linux/device.h
when did this got changed? And more to the point, why nobody bothered
to remove all the CONFIG_PM and CONFIG_HOTPLUG ifdefs splattered
around the kernel. It must be part of Greg's changes to remove class
devices. I am not sure this is all the right approach since
potentially it blots the kernel.
This would also means that the CONFIG_HOTPLUG for dev_uevent can go
away.
Regards
Marcel
next prev parent reply other threads:[~2008-08-04 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 12:33 [RFC] cfg80211: add PM hooks Johannes Berg
2008-08-04 16:15 ` Marcel Holtmann
2008-08-04 16:19 ` Johannes Berg
2008-08-04 16:27 ` Marcel Holtmann [this message]
2008-08-04 16:36 ` Johannes Berg
2008-08-04 16:39 ` Johannes Berg
2008-08-04 17:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6064CD72-8B4A-4F23-BCFA-4D656729E60D@holtmann.org \
--to=marcel@holtmann.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox