From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BEB5C77B75 for ; Tue, 18 Apr 2023 08:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231230AbjDRIPh (ORCPT ); Tue, 18 Apr 2023 04:15:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbjDRIPe (ORCPT ); Tue, 18 Apr 2023 04:15:34 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 542CD618A for ; Tue, 18 Apr 2023 01:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=8UW6ybr3e1Cm4qPC9xrTWnDCBJ859mXH3+qyEx+8l3g=; t=1681805732; x=1683015332; b=EsxppROZpe5V/UuET64dz7K9BTHwkxMjxYfxWgrfFMIpugh iaSZKuCiW3oYSl2DajvYOp3+hUhibx4+0CFDZSyXAZmuKiDuWVpQFJbxdD4Q4Su3SC6XZEauxXk0y jyB92vdDJ2Q6GOZE41vNMciufExdChDLh/OhDk6byFl+731KaBUv0FHnuRa5A5Ocoy+tw4sORX5a9 39zpgAK7ymnsq/cGKGuQSvXi4YCkILx7ytkAYI5E74MOK40G4rfrfXRybV5RQoj+mgSW6JOetGS6B dSmZV6T+2SWcAUXaKm7wCbc+3EygnA4o7c8LsZS1rOVUZSIyf0CfUCALuHreIncw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1pogUr-001XWn-35; Tue, 18 Apr 2023 10:15:30 +0200 Message-ID: <61268d31f8a6dd4eea10fcb6048d39244bc584e2.camel@sipsolutions.net> Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links From: Johannes Berg To: Wen Gong , linux-wireless@vger.kernel.org Cc: ath11k@lists.infradead.org Date: Tue, 18 Apr 2023 10:15:29 +0200 In-Reply-To: References: <20220902141259.377789-1-johannes@sipsolutions.net> <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid> <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com> <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net> <2de44394-cb93-7be4-481f-2d92788b8d28@quicinc.com> <351f74e0e1cd6e9724f97dbd042bdc5e04c44842.camel@sipsolutions.net> <545227cf18baac94ea8aa24dc08b250c47949541.camel@sipsolutions.net> <868131d13ed7c4c8b5d4938adcd71cf1ff8e9677.camel@sipsolutions.net> <5765e3c5-46d4-e92b-a93b-4a2649acff2a@quicinc.com> <37958ca93039114b98909d730ff57dd1d10bb68d.camel@sipsolutions.net> <91577d586475d290e08dee9e535cb6b4896e06d4.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2023-04-17 at 22:07 +0800, Wen Gong wrote: >=20 > OK. So I will try to put this in mac80211 layer, is it OK? >=20 I guess? I'm still not really sure why you even want it, but hey, that's up to you in a way. I really didn't like the suggestion with wiphy_iftype_ext_capab (or any other capability for that matter), it feels like it should be more dynamic, like maybe a new "add link" callback or something? At least then you can't blame mac80211 for when it breaks when you have two 5 GHz links ... johannes