From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
kvalo@codeaurora.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath11k: use cumulative survey statistics
Date: Tue, 05 May 2020 10:31:10 -0700 [thread overview]
Message-ID: <61f3dcc195fa4d877ddbd161523142ec@codeaurora.org> (raw)
In-Reply-To: <c786e982-fcd6-2368-6b2f-f09b265654d6@tu-ilmenau.de>
On 2020-05-04 23:53, Markus Theil wrote:
> Am 05.05.2020 um 01:37 schrieb Rajkumar Manoharan:
>> On 2020-05-04 08:41, Markus Theil wrote:
>>> ath11k currently reports survey results for the last interval between
>>> each
>>> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations,
>>> this
>>> can lead to unexpectedly small results, e.g. when hostapd uses survey
>>> data and iw survey dump is invoked in parallel. Fix this by returning
>>> cumulative results, that don't depend on the last invocation. Other
>>> drivers, e.g. ath9k or mt76 also use this behavior.
>>>
[...]
>> Markus,
>>
>> It depends on type of survey request is given to firmware. In ath11k,
>> firmware reports
>> accumulated values. So the above addition is wrong and report double
>> value. Have you
>> tested this change?
>>
>> -Rajkumar
> Ok, so please drop both of my patches. My assumptions were incomplete
> and too humble. I just assumed, ath10k and ath11k both use incremental
> surveys.
>
Markus,
The ath10k driver still counts survey stats incrementally. But it should
be handled by sending
appropriate survey request_type to firmware.
-Rajkumar
next prev parent reply other threads:[~2020-05-05 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:41 [PATCH 1/2] ath10k: use cumulative survey statistics Markus Theil
2020-05-04 15:41 ` [PATCH 2/2] ath11k: " Markus Theil
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-05 6:53 ` Markus Theil
2020-05-05 17:31 ` Rajkumar Manoharan [this message]
2020-05-04 16:29 ` [PATCH 1/2] ath10k: " Sven Eckelmann
2020-05-04 16:33 ` Markus Theil
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:52 ` Rajkumar Manoharan
2020-05-05 0:02 ` Ben Greear
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 15:37 ` Markus Theil
2020-05-05 18:32 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f3dcc195fa4d877ddbd161523142ec@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).