RE: [PATCH rtw-next 6/7] wifi: rtw89: 8922d: add set channel of BB part

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> On 23/03/2026 05:25, Ping-Ke Shih wrote:
> > The set channel of BB part is the main part, which according to channel
> > and bandwidth to configure CCK SCO, RX gain of LNA and TIA programmed
> > in efuse for CCK and OFDM rate, and spur elimination of CSI and NBI tones.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> > ---
> >  drivers/net/wireless/realtek/rtw89/core.h     |   2 +
> >  drivers/net/wireless/realtek/rtw89/reg.h      |  64 +-
> >  drivers/net/wireless/realtek/rtw89/rtw8922d.c | 820 ++++++++++++++++++
> >  3 files changed, 885 insertions(+), 1 deletion(-)
> >
> 
> [..]
> 
> > +
> > +static const struct rtw89_nbi_reg_def rtw8922d_nbi_reg_def[] = {
> > +     [RF_PATH_A] = {
> > +             .notch1_idx = {0x241A0, 0xFF},
> > +             .notch1_frac_idx = {0x241A0, 0xC00},
> > +             .notch1_en = {0x241A0, 0x1000},
> > +             .notch2_idx = {0x241AC, 0xFF},
> > +             .notch2_frac_idx = {0x241AC, 0xC00},
> > +             .notch2_en = {0x241AC, 0x1000},
> > +     },
> > +     [RF_PATH_B] = {
> > +             .notch1_idx = {0x245A0, 0xFF},
> > +             .notch1_frac_idx = {0x241A0, 0xC00},
> 
> Is that supposed to be 0x245A0 ?

Thanks for the finding. I'll fix it by v2.

> 
> > +             .notch1_en = {0x245A0, 0x1000},
> > +             .notch2_idx = {0x245AC, 0xFF},
> > +             .notch2_frac_idx = {0x245AC, 0xC00},
> > +             .notch2_en = {0x245AC, 0x1000},
> > +     },
> > +};
> > +
> 
> [...]