From: Alexander Wetzel <alexander@wetzel-home.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: Fix Extended Key ID auto activation
Date: Tue, 23 Apr 2019 22:59:40 +0200 [thread overview]
Message-ID: <62a76eb7-2cd4-65ed-e583-663d1d971820@wetzel-home.de> (raw)
In-Reply-To: <4464ea399dbbc1aca040ad8a4442a73f78cc38fb.camel@sipsolutions.net>
Am 23.04.19 um 14:14 schrieb Johannes Berg:
> On Mon, 2019-04-22 at 23:34 +0200, Alexander Wetzel wrote:
>> Only enable Extended Key ID support for drivers which are not supporting
>> crypto offload and also do not support A-MPDU.
>>
>> While any driver using SW crypto from mac80211 is generally able to also
>> support Extended Key ID these drivers are likely to mix keyIDs in
>> AMPDUs when rekeying.
>>
>> According to IEEE 802.11-2016 "9.7.3 A-MPDU contents" this is not
>> allowed.
>>
>
> I applied this (with some changes), but please resend the other patch as
> two separate patches to mac80211/hwsim.
I've just dropped you the updated patch for hwsim Extended Key ID
support. That's kind of critical for the attempt to get Extended Key ID
support merged in hostapd/wpa_supplicant.
The patch to allow ptk0 rekeys with hwsim should follow soon. (The PTK0
rekey patches I have for hostapd/wpa_supplicant still need serious work
anyhow and are far away to be ready for merge.)
Alexander
prev parent reply other threads:[~2019-04-23 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 21:34 [PATCH 1/2] mac80211: Fix Extended Key ID auto activation Alexander Wetzel
2019-04-22 21:34 ` [PATCH 2/2] mac80211_hwsim: Update feature flags Alexander Wetzel
2019-04-23 10:18 ` Johannes Berg
2019-04-23 12:14 ` [PATCH 1/2] mac80211: Fix Extended Key ID auto activation Johannes Berg
2019-04-23 20:59 ` Alexander Wetzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62a76eb7-2cd4-65ed-e583-663d1d971820@wetzel-home.de \
--to=alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox