* wil6210 driver compilation failure
@ 2013-07-20 18:37 Thomas Fjellstrom
2013-07-20 19:14 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Fjellstrom @ 2013-07-20 18:37 UTC (permalink / raw)
To: linux-wireless
Hi,
Recently while trying to figure out a separate issue, I did a
make allmodconfig and a make oldconfig with debian's default config on
the 3.10.1 kernel, and debian's config with 3.10.0.
It failed in the wil6210 driver.
The system it failed on is running a fresh install of Debian Sid, with gcc
4.8.1.
This is the error I got:
CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
drivers/net/wireless/ath/wil6210/debugfs.c: In function âwil_print_ringâ:
drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets in passing argument 5 of âhex_dump_to_bufferâ differ in signedness [-Werror=pointer-sign]
false);
^
In file included from include/linux/kernel.h:13:0,
from include/linux/cache.h:4,
from include/linux/time.h:4,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from drivers/net/wireless/ath/wil6210/debugfs.c:17:
include/linux/printk.h:361:13: note: expected âchar *â but argument is of type âunsigned char *â
extern void hex_dump_to_buffer(const void *buf, size_t len,
^
drivers/net/wireless/ath/wil6210/debugfs.c: In function âwil_txdesc_debugfs_showâ:
drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets in passing argument 5 of âhex_dump_to_bufferâ differ in signedness [-Werror=pointer-sign]
sizeof(printbuf), false);
^
In file included from include/linux/kernel.h:13:0,
from include/linux/cache.h:4,
from include/linux/time.h:4,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from drivers/net/wireless/ath/wil6210/debugfs.c:17:
include/linux/printk.h:361:13: note: expected âchar *â but argument is of type âunsigned char *â
extern void hex_dump_to_buffer(const void *buf, size_t len,
^
cc1: all warnings being treated as errors
make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
please excuse the mangled quotes, fresh install and I negelected to set up
the locale properly. It's fixed now, but it seems I need to restart X for it to
notice.
--
Thomas Fjellstrom
thomas@fjellstrom.ca
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: wil6210 driver compilation failure
2013-07-20 18:37 wil6210 driver compilation failure Thomas Fjellstrom
@ 2013-07-20 19:14 ` Larry Finger
2013-07-20 19:40 ` Thomas Fjellstrom
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-07-20 19:14 UTC (permalink / raw)
To: thomas; +Cc: linux-wireless, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 2765 bytes --]
On 07/20/2013 01:37 PM, Thomas Fjellstrom wrote:
> Hi,
>
> Recently while trying to figure out a separate issue, I did a
> make allmodconfig and a make oldconfig with debian's default config on
> the 3.10.1 kernel, and debian's config with 3.10.0.
>
> It failed in the wil6210 driver.
>
> The system it failed on is running a fresh install of Debian Sid, with gcc
> 4.8.1.
>
> This is the error I got:
>
> CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
> drivers/net/wireless/ath/wil6210/debugfs.c: In function âwil_print_ringâ:
> drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets in passing argument 5 of âhex_dump_to_bufferâ differ in signedness [-Werror=pointer-sign]
> false);
> ^
> In file included from include/linux/kernel.h:13:0,
> from include/linux/cache.h:4,
> from include/linux/time.h:4,
> from include/linux/stat.h:18,
> from include/linux/module.h:10,
> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> include/linux/printk.h:361:13: note: expected âchar *â but argument is of type âunsigned char *â
> extern void hex_dump_to_buffer(const void *buf, size_t len,
> ^
> drivers/net/wireless/ath/wil6210/debugfs.c: In function âwil_txdesc_debugfs_showâ:
> drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets in passing argument 5 of âhex_dump_to_bufferâ differ in signedness [-Werror=pointer-sign]
> sizeof(printbuf), false);
> ^
> In file included from include/linux/kernel.h:13:0,
> from include/linux/cache.h:4,
> from include/linux/time.h:4,
> from include/linux/stat.h:18,
> from include/linux/module.h:10,
> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> include/linux/printk.h:361:13: note: expected âchar *â but argument is of type âunsigned char *â
> extern void hex_dump_to_buffer(const void *buf, size_t len,
> ^
> cc1: all warnings being treated as errors
> make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
> make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
> make[3]: *** [drivers/net/wireless/ath] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> please excuse the mangled quotes, fresh install and I negelected to set up
> the locale properly. It's fixed now, but it seems I need to restart X for it to
> notice.
This error should be fixed by the attached patch. Please test.
Note that my system did not issue a warning for this "problem". It seems we have
different warnings turned on in the compiler.
Larry
[-- Attachment #2: wil6210_compile --]
[-- Type: text/plain, Size: 613 bytes --]
Index: linux-2.6/drivers/net/wireless/ath/wil6210/debugfs.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/ath/wil6210/debugfs.c
+++ linux-2.6/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -145,7 +145,7 @@ static void wil_print_ring(struct seq_fi
le16_to_cpu(hdr.type), hdr.flags);
if (len <= MAX_MBOXITEM_SIZE) {
int n = 0;
- unsigned char printbuf[16 * 3 + 2];
+ char printbuf[16 * 3 + 2];
unsigned char databuf[MAX_MBOXITEM_SIZE];
void __iomem *src = wmi_buffer(wil, d.addr) +
sizeof(struct wil6210_mbox_hdr);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: wil6210 driver compilation failure
2013-07-20 19:14 ` Larry Finger
@ 2013-07-20 19:40 ` Thomas Fjellstrom
2013-07-20 21:12 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Fjellstrom @ 2013-07-20 19:40 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Greg Kroah-Hartman
On Sat 20 July 2013 14:14:25 Larry Finger wrote:
> On 07/20/2013 01:37 PM, Thomas Fjellstrom wrote:
> > Hi,
> >
> > Recently while trying to figure out a separate issue, I did a
> > make allmodconfig and a make oldconfig with debian's default config on
> > the 3.10.1 kernel, and debian's config with 3.10.0.
> >
> > It failed in the wil6210 driver.
> >
> > The system it failed on is running a fresh install of Debian Sid, with gcc
> > 4.8.1.
> >
> > This is the error I got:
> > CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
> >
> > drivers/net/wireless/ath/wil6210/debugfs.c: In function âwil_print_ringâ:
> > drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets
> > in passing argument 5 of âhex_dump_to_bufferâ differ in signedness
> > [-Werror=pointer-sign]>
> > false);
> > ^
> >
> > In file included from include/linux/kernel.h:13:0,
> >
> > from include/linux/cache.h:4,
> > from include/linux/time.h:4,
> > from include/linux/stat.h:18,
> > from include/linux/module.h:10,
> >
> > from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> > include/linux/printk.h:361:13: note: expected âchar *â but argument is of
> > type âunsigned char *â>
> > extern void hex_dump_to_buffer(const void *buf, size_t len,
> >
> > ^
> >
> > drivers/net/wireless/ath/wil6210/debugfs.c: In function
> > âwil_txdesc_debugfs_showâ:
> > drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets
> > in passing argument 5 of âhex_dump_to_bufferâ differ in signedness
> > [-Werror=pointer-sign]>
> > sizeof(printbuf), false);
> > ^
> >
> > In file included from include/linux/kernel.h:13:0,
> >
> > from include/linux/cache.h:4,
> > from include/linux/time.h:4,
> > from include/linux/stat.h:18,
> > from include/linux/module.h:10,
> >
> > from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> > include/linux/printk.h:361:13: note: expected âchar *â but argument is of
> > type âunsigned char *â>
> > extern void hex_dump_to_buffer(const void *buf, size_t len,
> >
> > ^
> >
> > cc1: all warnings being treated as errors
> > make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
> > make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
> > make[3]: *** [drivers/net/wireless/ath] Error 2
> > make[2]: *** [drivers/net/wireless] Error 2
> > make[1]: *** [drivers/net] Error 2
> > make: *** [drivers] Error 2
> >
> > please excuse the mangled quotes, fresh install and I negelected to set up
> > the locale properly. It's fixed now, but it seems I need to restart X for
> > it to notice.
>
> This error should be fixed by the attached patch. Please test.
>
> Note that my system did not issue a warning for this "problem". It seems we
> have different warnings turned on in the compiler.
The warnings have gone away, and the first error, but the second one is still
there.
> Larry
--
Thomas Fjellstrom
thomas@fjellstrom.ca
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: wil6210 driver compilation failure
2013-07-20 19:40 ` Thomas Fjellstrom
@ 2013-07-20 21:12 ` Larry Finger
2013-07-20 22:48 ` Thomas Fjellstrom
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-07-20 21:12 UTC (permalink / raw)
To: thomas; +Cc: linux-wireless, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
On 07/20/2013 02:40 PM, Thomas Fjellstrom wrote:
>
> The warnings have gone away, and the first error, but the second one is still
> there.
Sorry, I missed the second one in your original message. Does this one fix it?
Larry
[-- Attachment #2: wil6210_compile --]
[-- Type: text/plain, Size: 882 bytes --]
Index: linux-2.6/drivers/net/wireless/ath/wil6210/debugfs.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/ath/wil6210/debugfs.c
+++ linux-2.6/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -145,7 +145,7 @@ static void wil_print_ring(struct seq_fi
le16_to_cpu(hdr.type), hdr.flags);
if (len <= MAX_MBOXITEM_SIZE) {
int n = 0;
- unsigned char printbuf[16 * 3 + 2];
+ char printbuf[16 * 3 + 2];
unsigned char databuf[MAX_MBOXITEM_SIZE];
void __iomem *src = wmi_buffer(wil, d.addr) +
sizeof(struct wil6210_mbox_hdr);
@@ -416,7 +416,7 @@ static int wil_txdesc_debugfs_show(struc
seq_printf(s, " SKB = %p\n", skb);
if (skb) {
- unsigned char printbuf[16 * 3 + 2];
+ char printbuf[16 * 3 + 2];
int i = 0;
int len = le16_to_cpu(d->dma.length);
void *p = skb->data;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: wil6210 driver compilation failure
2013-07-20 21:12 ` Larry Finger
@ 2013-07-20 22:48 ` Thomas Fjellstrom
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Fjellstrom @ 2013-07-20 22:48 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Greg Kroah-Hartman
On Sat 20 July 2013 16:12:10 Larry Finger wrote:
> On 07/20/2013 02:40 PM, Thomas Fjellstrom wrote:
> > The warnings have gone away, and the first error, but the second one is
> > still there.
>
> Sorry, I missed the second one in your original message. Does this one fix
> it?
That seems to have done the trick.
> Larry
--
Thomas Fjellstrom
thomas@fjellstrom.ca
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-20 22:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-20 18:37 wil6210 driver compilation failure Thomas Fjellstrom
2013-07-20 19:14 ` Larry Finger
2013-07-20 19:40 ` Thomas Fjellstrom
2013-07-20 21:12 ` Larry Finger
2013-07-20 22:48 ` Thomas Fjellstrom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).