public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: Jouni Malinen <j@w1.fi>
Cc: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: Looking for non-NIC hardware-offload for wpa2 decrypt.
Date: Thu, 31 Jul 2014 22:45:47 +0200	[thread overview]
Message-ID: <6460230.VGl66UFULp@debian64> (raw)
In-Reply-To: <20140731200522.GA8868@w1.fi>

On Thursday, July 31, 2014 11:05:22 PM Jouni Malinen wrote:
> On Wed, Jul 30, 2014 at 08:59:33PM +0200, Christian Lamparter wrote:
> > If you have disabled rx-decrypt logic of ath10k, then why isn't _aesni_dec1
> > or aes_decrypt listed in the perf top result? I think they should be. Have you
> > removed them from the "perf top results" or are they really absent 
> > altogether? 
> > 
> > Because, from this perf result, it looks like your CPU is not burden by the
> > incoming RX at all?! Instead it is busy with the encryption of frames
> > it will be transmitting (in case of tcp, this could be tcp acks).
> 
> Keep in mind that this is CCMP, i.e., AES in CCM (Counter with CBC-MAC)
> mode. The CCM mode uses only the block cipher encryption function, i.e.,
> you won't be seeing aes_decrypt or _aesni_dec1 for this even on the RX
> path (AES encryption operations are used to generate the key stream
> blocks for CCM decryption).
Yes, I remember this detail/the old days (before 3.12/3.13?). Back then
ieee80211_aes_ccm_decrypt did exactly that. But these semantic pitfalls
were taken care of by the following commit:

commit 7ec7c4a9a686c608315739ab6a2b0527a240883c (from wireless-testing.git)
Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Thu Oct 10 09:55:20 2013 +0200

  mac80211: port CCMP to cryptoapi's CCM driver
   
  Use the generic CCM aead chaining mode driver rather than a local
  implementation that sits right on top of the core AES cipher.
  
  This allows the use of accelerated implementations of either
  CCM as a whole or the CTR mode which it encapsulates.
  [...]

Regards
Christian

  reply	other threads:[~2014-07-31 20:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31  4:40 Looking for non-NIC hardware-offload for wpa2 decrypt Ben Greear
2014-03-31 18:09 ` Christian Lamparter
2014-07-28 20:50   ` Ben Greear
2014-07-29 22:29     ` Christian Lamparter
2014-07-29 22:50       ` Ben Greear
2014-07-30 18:59         ` Christian Lamparter
2014-07-30 19:08           ` Ben Greear
2014-07-31 20:05           ` Jouni Malinen
2014-07-31 20:45             ` Christian Lamparter [this message]
2014-08-05 23:09               ` Ben Greear
2014-08-07 14:05                 ` Christian Lamparter
2014-08-07 17:45                   ` Ben Greear
2014-08-10 13:44                     ` Christian Lamparter
2014-08-12 18:34                       ` Ben Greear
2014-08-14 12:39                         ` Christian Lamparter
2014-08-14 17:09                           ` Ben Greear
2014-08-19 18:18                             ` Ben Greear
2014-08-20 20:47                               ` Christian Lamparter
2014-08-20 21:04                                 ` Ben Greear
2014-08-22 22:55                                   ` Christian Lamparter
2014-07-30  7:06       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6460230.VGl66UFULp@debian64 \
    --to=chunkeey@googlemail.com \
    --cc=greearb@candelatech.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox