From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Arend van Spriel <aspriel@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@kernel.org>, Len Baker <len.baker@gmx.com>,
Shawn Guo <shawn.guo@linaro.org>,
Hector Martin <marcan@marcan.st>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: use strreplace() in brcmf_of_probe()
Date: Fri, 17 Jun 2022 17:14:21 +0200 [thread overview]
Message-ID: <646e9821-5fb0-98ee-0ead-17d9b2b15437@broadcom.com> (raw)
In-Reply-To: <YqrhsKcjEA7B2pC4@kili>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On 6/16/2022 9:54 AM, Dan Carpenter wrote:
> The for loop in brcmf_of_probe() would ideally end with something like
> "i <= strlen(board_type)" instead of "i < board_type[i]". But
> fortunately, the two are equivalent.
>
> Anyway, it's simpler to use strreplace() instead.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> I sent something like this last year but I did something wrong and it
> never made it patchwork. This is basically a new patch.
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2022-06-17 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 7:54 [PATCH] brcmfmac: use strreplace() in brcmf_of_probe() Dan Carpenter
2022-06-16 13:08 ` Linus Walleij
2022-06-17 15:14 ` Arend van Spriel [this message]
2022-07-28 9:55 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646e9821-5fb0-98ee-0ead-17d9b2b15437@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=len.baker@gmx.com \
--cc=linus.walleij@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox