From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: akolli@qti.qualcomm.com
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
akolli@codeaurora.org
Subject: Re: [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal
Date: Fri, 08 Dec 2017 13:12:22 +0100 [thread overview]
Message-ID: <6476910.M9FJQ0px1r@bentobox> (raw)
In-Reply-To: <1495709483-29793-1-git-send-email-akolli@qti.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]
On Donnerstag, 25. Mai 2017 16:21:23 CET akolli@qti.qualcomm.com wrote:
> From: Anilkumar Kolli <akolli@qti.qualcomm.com>
>
> QCA99X0, QCA9888, QCA9984 supports calibration data in
> either OTP or DT/pre-cal file. Current ath10k supports
> Calibration data from OTP only.
>
> If caldata is loaded from DT/pre-cal file, fetching board id
> and applying calibration parameters like tx power gets failed.
>
> error log:
> [ 15.733663] ath10k_pci 0000:01:00.0: failed to fetch board file: -2
> [ 15.741474] ath10k_pci 0000:01:00.0: could not probe fw (-2)
>
> This patch adds calibration data support from DT/pre-cal
> file. Below parameters are used to get board id and
> applying calibration parameters from cal data.
>
> EEPROM[OTP] FLASH[DT/pre-cal file]
> Cal param 0x700 0x10000
> Board id 0x10 0x8000
>
> Tested on QCA9888 with pre-cal file.
>
> Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/bmi.h | 2 ++
> drivers/net/wireless/ath/ath10k/core.c | 16 +++++++++++++---
> 2 files changed, 15 insertions(+), 3 deletions(-)
Just tried this on an QCA9984 which doesn't seem to have the calibration data in the PCI EEPROM.
[ 71.728929] ath10k_pci 0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id 0x00000000 sub 168c:cafe
[ 71.732926] ath10k_pci 0000:01:00.0: kconfig debug 1 debugfs 1 tracing 0 dfs 1 testmode 1
[ 71.752282] ath10k_pci 0000:01:00.0: firmware ver 10.4-ct-9984-fW-009-dfa0083 api 5 features peer-flow-ctrl crc32 7198d117
[ 73.805730] ath10k_pci 0000:01:00.0: unable to read from the device
[ 73.805769] ath10k_pci 0000:01:00.0: could not execute otp for board id check: -110
It works when I use the pre-cal data as calibration data. The checksum in the
pre-cal seems to be correct. Also the pre-cal data from 0:ART for the 2.4GHz
and 5GHz QCA4019 seem to work perfectly fine.
Anything which I could have missed or what I could test? Btw. I've also tested
the non-ct firmware (aka the official one from QCA).
Kind
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-08 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 10:51 [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal akolli
2017-06-01 12:59 ` Kalle Valo
2017-12-08 12:12 ` Sven Eckelmann [this message]
2017-12-08 12:35 ` [PATCH] " akolli
2017-12-08 13:40 ` Sven Eckelmann
2017-12-11 13:20 ` akolli
2017-12-11 14:28 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6476910.M9FJQ0px1r@bentobox \
--to=sven.eckelmann@openmesh.com \
--cc=akolli@codeaurora.org \
--cc=akolli@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).