Linux wireless drivers development
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath: wil6210: Fix build error
Date: Tue, 23 Jul 2013 10:06:46 +0300	[thread overview]
Message-ID: <6487488.19IqyPtizJ@lx-vladimir> (raw)
In-Reply-To: <20130722161554.GR17130@pogo>

On Monday, July 22, 2013 09:17:01 AM Luis R. Rodriguez wrote:
> On Sun, Jul 21, 2013 at 10:06:31AM +0300, Vladimir Kondratiev wrote:
> > Hmm, I have no warning for this with neither 3.10 nor 3.11 kernel version; but
> > patch is correct, and here is my
> > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> 
> If you agree with a patch you don't say you Sign-off-by it as well,
> you say Acked-by. The Signed-off-by tag has a very specific meaning
> from development to a maintainer's hands, and its definition is on
> the Developer Certificate or Origin.
> 
> So in this case Acked-by is better.
> 
>   Luis

<drop most of CC>

I thought that I need to add Signed-off-by: as driver's maintainer, because
(quote Documentation/SubmittingPatches):
---
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
---

This is similar to other maintainers adding its Signed-off-by:.
Or, is driver's maintainer an exception from the rule quoted above?

Thanks, Vladimir

  reply	other threads:[~2013-07-23  7:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21  2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
2013-07-21  7:06 ` Vladimir Kondratiev
2013-07-21 15:14   ` Larry Finger
2013-07-21 15:35     ` Thomas Fjellstrom
2013-07-21 15:52       ` Vladimir Kondratiev
2013-07-21 16:55         ` Kalle Valo
2013-07-22  1:45         ` Ben Hutchings
2013-07-22  9:56           ` Vladimir Kondratiev
2013-07-22 16:17   ` Luis R. Rodriguez
2013-07-23  7:06     ` Vladimir Kondratiev [this message]
2013-07-23  7:13       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6487488.19IqyPtizJ@lx-vladimir \
    --to=qca_vkondrat@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox