RE: [PATCH 16/20] wifi: rtw88: Add rtw8812a_table.{c,h}

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> These contain various arrays for initialising RTL8812AU. Also TX power
> limits.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
>  .../wireless/realtek/rtw88/rtw8812a_table.c   | 2812 +++++++++++++++++
>  .../wireless/realtek/rtw88/rtw8812a_table.h   |   26 +
>  2 files changed, 2838 insertions(+)
>  create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8812a_table.c
>  create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8812a_table.h
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8812a_table.c
> b/drivers/net/wireless/realtek/rtw88/rtw8812a_table.c
> new file mode 100644
> index 000000000000..0d005d88b0a4
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8812a_table.c
> @@ -0,0 +1,2812 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +/* Copyright(c) 2018-2019  Realtek Corporation

year 2024

[...]

> +
> +const struct rtw_pwr_seq_cmd *card_enable_flow_8812a[] = {
> +       trans_carddis_to_cardemu_8812a,
> +       trans_cardemu_to_act_8812a,
> +       NULL
> +};
> +
> +const struct rtw_pwr_seq_cmd *enter_lps_flow_8812a[] = {
> +       trans_act_to_lps_8812a,
> +       NULL
> +};
> +
> +const struct rtw_pwr_seq_cmd *card_disable_flow_8812a[] = {
> +       trans_act_to_cardemu_8812a,
> +       trans_cardemu_to_carddis_8812a,
> +       NULL
> +};
> +

These three array should be 'const struct rtw_pwr_seq_cmd * const ...'.

I don't expect things in ".data" section.

$ objdump  -t rtw8812a_table.o | grep "\.data"
0000000000000000 g     O .data  0000000000000018 card_disable_flow_8812a
0000000000000020 g     O .data  0000000000000010 enter_lps_flow_8812a
0000000000000030 g     O .data  0000000000000018 card_enable_flow_8812a


[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8812a_table.h
> b/drivers/net/wireless/realtek/rtw88/rtw8812a_table.h
> new file mode 100644
> index 000000000000..15ecc72b175a
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8812a_table.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
> +/* Copyright(c) 2018-2019  Realtek Corporation

year 2024

> + */
> +
> +#ifndef __RTW8812A_TABLE_H__
> +#define __RTW8812A_TABLE_H__
> +
> +extern const struct rtw_table rtw8812a_mac_tbl;
> +extern const struct rtw_table rtw8812a_agc_tbl;
> +extern const struct rtw_table rtw8812a_agc_diff_lb_tbl;
> +extern const struct rtw_table rtw8812a_agc_diff_hb_tbl;
> +extern const struct rtw_table rtw8812a_bb_tbl;
> +extern const struct rtw_table rtw8812a_bb_pg_tbl;
> +extern const struct rtw_table rtw8812a_bb_pg_rfe3_tbl;
> +extern const struct rtw_table rtw8812a_rf_a_tbl;
> +extern const struct rtw_table rtw8812a_rf_b_tbl;
> +extern const struct rtw_table rtw8812a_txpwr_lmt_tbl;
> +
> +extern const struct rtw_pwr_seq_cmd *card_enable_flow_8812a[];
> +extern const struct rtw_pwr_seq_cmd *enter_lps_flow_8812a[];
> +extern const struct rtw_pwr_seq_cmd *card_disable_flow_8812a[];
> +
> +extern const struct rtw_pwr_track_tbl rtw8812a_rtw_pwr_track_tbl;
> +extern const struct rtw_pwr_track_tbl rtw8812a_rtw_pwr_track_rfe3_tbl;
> +
> +#endif
> --
> 2.46.0