* [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
@ 2016-09-26 15:15 Matias Mucciolo
2016-09-26 15:37 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Matias Mucciolo @ 2016-09-26 15:15 UTC (permalink / raw)
To: Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Cc: linux-wireless, devel, linux-kernel
- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index b052628..802bb1d 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
#define ERR BIT(3)
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
2016-09-26 15:15 [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared Matias Mucciolo
@ 2016-09-26 15:37 ` Greg Kroah-Hartman
2016-09-26 15:44 ` Matias Mucciolo
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-26 15:37 UTC (permalink / raw)
To: Matias Mucciolo
Cc: Aditya Shankar, Ganesh Krishna, devel, linux-wireless,
linux-kernel
On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote:
>
> - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
I don't think that was the full warning, as that does not make much
sense to me, does it to you?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
2016-09-26 15:37 ` Greg Kroah-Hartman
@ 2016-09-26 15:44 ` Matias Mucciolo
2016-09-26 15:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Matias Mucciolo @ 2016-09-26 15:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Aditya Shankar, Ganesh Krishna, devel, linux-wireless,
linux-kernel
hi
sorry...this is the full warning:
drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
--
Matias Mucciolo
Area de Infraestructura.
Piedras 737 C.A.B.A
SUTEBA
On Monday 26 September 2016 17:37:33 Greg Kroah-Hartman wrote:
> On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote:
> >
> > - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
>
> I don't think that was the full warning, as that does not make much
> sense to me, does it to you?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
2016-09-26 15:44 ` Matias Mucciolo
@ 2016-09-26 15:52 ` Greg Kroah-Hartman
2016-09-26 16:13 ` [PATCH] staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static? Matias Mucciolo
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-26 15:52 UTC (permalink / raw)
To: Matias Mucciolo
Cc: devel, Aditya Shankar, linux-wireless, linux-kernel,
Ganesh Krishna
On Mon, Sep 26, 2016 at 12:44:24PM -0300, Matias Mucciolo wrote:
>
> hi
>
> sorry...this is the full warning:
>
> drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
the "should it be static" is the key here, right? Care to fix this up
and resend it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static?
2016-09-26 15:52 ` Greg Kroah-Hartman
@ 2016-09-26 16:13 ` Matias Mucciolo
0 siblings, 0 replies; 5+ messages in thread
From: Matias Mucciolo @ 2016-09-26 16:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Aditya Shankar, Ganesh Krishna
Cc: devel, linux-wireless, linux-kernel
- Fixed a sparse warning:
wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index b052628..802bb1d 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
#define ERR BIT(3)
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-26 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 15:15 [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared Matias Mucciolo
2016-09-26 15:37 ` Greg Kroah-Hartman
2016-09-26 15:44 ` Matias Mucciolo
2016-09-26 15:52 ` Greg Kroah-Hartman
2016-09-26 16:13 ` [PATCH] staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static? Matias Mucciolo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).