From: Ping-Ke Shih <pkshih@realtek.com>
To: Doug Brown <doug@schmorgal.com>, Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Dan Williams <dcbw@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
"libertas-dev@lists.infradead.org"
<libertas-dev@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct
Date: Tue, 17 Jan 2023 03:39:44 +0000 [thread overview]
Message-ID: <651627a8399f4cb49feb336e6f5bd9dc@realtek.com> (raw)
In-Reply-To: <20230116202126.50400-2-doug@schmorgal.com>
> -----Original Message-----
> From: Doug Brown <doug@schmorgal.com>
> Sent: Tuesday, January 17, 2023 4:21 AM
> To: Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: Dan Williams <dcbw@redhat.com>; Simon Horman <simon.horman@corigine.com>;
> libertas-dev@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Doug Brown
> <doug@schmorgal.com>
> Subject: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct
>
> This struct is currently unused, but it will be used in future patches.
> Fix the code style to not use camel case.
>
> Signed-off-by: Doug Brown <doug@schmorgal.com>
> ---
> drivers/net/wireless/marvell/libertas/types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/types.h
> b/drivers/net/wireless/marvell/libertas/types.h
> index cd4ceb6f885d..398e3272e85f 100644
> --- a/drivers/net/wireless/marvell/libertas/types.h
> +++ b/drivers/net/wireless/marvell/libertas/types.h
> @@ -105,7 +105,7 @@ struct mrvl_ie_header {
>
> struct mrvl_ie_data {
> struct mrvl_ie_header header;
> - u8 Data[1];
> + u8 data[1];
data[]. see [1]
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
> } __packed;
>
> struct mrvl_ie_rates_param_set {
> --
> 2.34.1
next prev parent reply other threads:[~2023-01-17 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 20:21 [PATCH v3 0/4] wifi: libertas: IE handling fixes Doug Brown
2023-01-16 20:21 ` [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct Doug Brown
2023-01-17 3:39 ` Ping-Ke Shih [this message]
2023-01-17 6:37 ` Doug Brown
2023-01-16 20:21 ` [PATCH v3 2/4] wifi: libertas: only add RSN/WPA IE in lbs_add_wpa_tlv Doug Brown
2023-01-17 8:59 ` Simon Horman
2023-01-18 6:35 ` Doug Brown
2023-01-18 9:14 ` Simon Horman
2023-01-16 20:21 ` [PATCH v3 3/4] wifi: libertas: add new TLV type for WPS enrollee IE Doug Brown
2023-01-16 20:21 ` [PATCH v3 4/4] wifi: libertas: add support for WPS enrollee IE in probe requests Doug Brown
2023-01-17 19:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651627a8399f4cb49feb336e6f5bd9dc@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=doug@schmorgal.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).