Re: [PATCH wireless-next v5 2/2] wifi: mac80211_hwsim: Add UHR capabilities to the driver

[Karthikeyan Kathirvel <karthikeyan.kathirvel@oss.qualcomm.com>]

On 3/4/2026 4:19 PM, Johannes Berg wrote:
> On Wed, 2026-03-04 at 14:23 +0530, Karthikeyan Kathirvel wrote:
>>
>> +++ b/drivers/net/wireless/virtual/mac80211_hwsim.c
>> @@ -4478,6 +4478,43 @@ static const struct ieee80211_sband_iftype_data sband_capa_2ghz[] = {
>>   			},
>>   			/* PPE threshold information is not supported */
>>   		},
>> +		.uhr_cap = {
> 
> Missing from the context, but this is non-AP side.
> 
>> +			.has_uhr = true,
>> +			.mac = {
>> +				.mac_cap[0] =
>> +					IEEE80211_UHR_MAC_CAP0_DPS_SUPP |
>> +					IEEE80211_UHR_MAC_CAP0_DPS_AP_STATIC_HCM_SUPP |
> 
> "Reserved for a non-AP STA."
> 

Yes it is applicable only for Mobile AP, neither supported for AP or 
non-AP STA, but I see only this I have missed it, remaining seems to be 
correct at to my knowledge.

> Maybe we're just better off doing this as we implement features?
>
Agree! I will leave this decision to you :)

> I've applied patch 1 with some minor edits.
> 
Thanks :)

> johannes