public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>,
	jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property
Date: Tue, 13 Jan 2026 08:29:10 +0100	[thread overview]
Message-ID: <6777df67-e6db-4f11-a971-9627fe86765e@kernel.org> (raw)
In-Reply-To: <0ad4722d-1557-4d8d-ae45-c0fdf893067f@oss.qualcomm.com>

On 12/01/2026 20:51, Jeff Johnson wrote:
> On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote:
>> On 11/12/2025 17:44, Jeff Johnson wrote:
>>> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>>>> The firmware-name property was introduced to allow end-users and
>>>> integrators to select usecase specific firmware for the WCN6855.
>>>> However, specifying firmware for an M.2 WLAN module in the Device
>>>> Tree is not appropriate. Instead, this functionality will be handled
>>>> within the ath11k driver.
>>>>
>>>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
>>>> ---
>>>>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> index e34d42a30192..0162e365798b 100644
>>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> @@ -37,6 +37,7 @@ properties:
>>>>  
>>>>    firmware-name:
>>>>      maxItems: 1
>>>> +    deprecated: true
>>>>      description:
>>>>        If present, a board or platform specific string used to lookup
>>>>        usecase-specific firmware files for the device.
>>>
>>> The driver patch completely removes support for this, so is this really
>>> considered deprecated? Or should this actually be considered obsolete and
>>
>> That's silent ABI break. I will formally NAK the patch.
>>
>>
>>> completely removed?
>>>
>>> Do any DTS files actually reference this?
>>>
>>> /jeff
>>
>>
>> Best regards,
>> Krzysztof
> 
> Krzysztof,
> Can you check the v2 to see if you still want to NAK?
> 
> https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com
> 

First, yes, still NAK.

Second, that patch faked Rob's tag, so it is unacceptable!

Best regards,
Krzysztof

  reply	other threads:[~2026-01-13  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  7:10 [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan
2025-12-04  7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan
2025-12-11  1:38   ` Baochen Qiang
2025-12-12  3:24   ` Krzysztof Kozlowski
2025-12-04  7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan
2025-12-09 19:56   ` Rob Herring (Arm)
2025-12-11 16:44   ` Jeff Johnson
2025-12-12  3:23     ` Krzysztof Kozlowski
2026-01-12 19:51       ` Jeff Johnson
2026-01-13  7:29         ` Krzysztof Kozlowski [this message]
2025-12-14  2:08     ` Miaoqing Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6777df67-e6db-4f11-a971-9627fe86765e@kernel.org \
    --to=krzk@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miaoqing.pan@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox