* [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible
@ 2025-12-04 7:10 Miaoqing Pan
2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan
2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan
0 siblings, 2 replies; 11+ messages in thread
From: Miaoqing Pan @ 2025-12-04 7:10 UTC (permalink / raw)
To: jjohnson, johannes, robh, krzk+dt, conor+dt
Cc: ath11k, linux-wireless, linux-kernel, devicetree, Miaoqing Pan
The 'firmware-name' property was introduced to allow end-users and
integrators to select use-case-specific firmware for the WCN6855.
But for M.2 WLAN chips, there is no suitable DTS node to specify
the 'firmware-name' property. In addition, assigning firmware for
the M.2 PCIe interface causes chips that do not use use-case-specific
firmware to fail. Therefore, abandoning the approach of specifying
firmware in DTS. As an alternative, propose a static lookup table
mapping device compatible to firmware names.
Miaoqing Pan (2):
wifi: ath11k: add usecase firmware handling based on device compatible
dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name'
property
.../net/wireless/qcom,ath11k-pci.yaml | 1 +
drivers/net/wireless/ath/ath11k/core.c | 37 ++++++++++++++++++-
drivers/net/wireless/ath/ath11k/core.h | 7 ++--
3 files changed, 40 insertions(+), 5 deletions(-)
base-commit: d0309c054362a235077327b46f727bc48878a3bc
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible 2025-12-04 7:10 [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan @ 2025-12-04 7:10 ` Miaoqing Pan 2025-12-11 1:38 ` Baochen Qiang 2025-12-12 3:24 ` Krzysztof Kozlowski 2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan 1 sibling, 2 replies; 11+ messages in thread From: Miaoqing Pan @ 2025-12-04 7:10 UTC (permalink / raw) To: jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree, Miaoqing Pan For M.2 WLAN chips, there is no suitable DTS node to specify the firmware-name property. In addition, assigning firmware for the M.2 PCIe interface causes chips that do not use usecase specific firmware to fail. Therefore, abandoning the approach of specifying firmware in DTS. As an alternative, propose a static lookup table mapping device compatible to firmware names. Currently, only WCN6855 HW2.1 requires this. For details on usecase specific firmware, see: https://lore.kernel.org/all/20250522013444.1301330-3-miaoqing.pan@oss.qualcomm.com/. Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 Fixes: edbbc647c4f3 ("wifi: ath11k: support usercase-specific firmware overrides") Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> --- drivers/net/wireless/ath/ath11k/core.c | 37 +++++++++++++++++++++++++- drivers/net/wireless/ath/ath11k/core.h | 7 +++-- 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 812686173ac8..a4a3a65c7752 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: BSD-3-Clause-Clear /* * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. */ @@ -997,6 +996,42 @@ static const struct dmi_system_id ath11k_pm_quirk_table[] = { {} }; +static const struct __ath11k_core_usecase_firmware_table { + u32 hw_rev; + const char *compatible; + const char *firmware_name; +} ath11k_core_usecase_firmware_table[] = { + { ATH11K_HW_WCN6855_HW21, "qcom,lemans-evk", "nfa765"}, + { ATH11K_HW_WCN6855_HW21, "qcom,monaco-evk", "nfa765"}, + { ATH11K_HW_WCN6855_HW21, "qcom,hamoa-iot-evk", "nfa765"}, + { /* Sentinel */ } +}; + +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab) +{ + struct device_node *root __free(device_node) = of_find_node_by_path("/"); + const struct __ath11k_core_usecase_firmware_table *entry = NULL; + int i, count = of_property_count_strings(root, "compatible"); + const char *compatible = NULL; + + for (i = 0; i < count; i++) { + if (of_property_read_string_index(root, "compatible", i, + &compatible) < 0) + continue; + + entry = ath11k_core_usecase_firmware_table; + while (entry->compatible) { + if (ab->hw_rev == entry->hw_rev && + !strcmp(entry->compatible, compatible)) + return entry->firmware_name; + entry++; + } + } + + return NULL; +} +EXPORT_SYMBOL(ath11k_core_get_usecase_firmware); + void ath11k_fw_stats_pdevs_free(struct list_head *head) { struct ath11k_fw_stats_pdev *i, *tmp; diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h index e8780b05ce11..f8fcd897ebd2 100644 --- a/drivers/net/wireless/ath/ath11k/core.h +++ b/drivers/net/wireless/ath/ath11k/core.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause-Clear */ /* * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. */ #ifndef ATH11K_CORE_H @@ -1275,6 +1275,7 @@ bool ath11k_core_coldboot_cal_support(struct ath11k_base *ab); const struct firmware *ath11k_core_firmware_request(struct ath11k_base *ab, const char *filename); +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab); static inline const char *ath11k_scan_state_str(enum ath11k_scan_state state) { @@ -1325,9 +1326,7 @@ static inline void ath11k_core_create_firmware_path(struct ath11k_base *ab, const char *filename, void *buf, size_t buf_len) { - const char *fw_name = NULL; - - of_property_read_string(ab->dev->of_node, "firmware-name", &fw_name); + const char *fw_name = ath11k_core_get_usecase_firmware(ab); if (fw_name && strncmp(filename, "board", 5)) snprintf(buf, buf_len, "%s/%s/%s/%s", ATH11K_FW_DIR, -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible 2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan @ 2025-12-11 1:38 ` Baochen Qiang 2025-12-12 3:24 ` Krzysztof Kozlowski 1 sibling, 0 replies; 11+ messages in thread From: Baochen Qiang @ 2025-12-11 1:38 UTC (permalink / raw) To: Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 12/4/2025 3:10 PM, Miaoqing Pan wrote: > For M.2 WLAN chips, there is no suitable DTS node to specify the > firmware-name property. In addition, assigning firmware for the > M.2 PCIe interface causes chips that do not use usecase specific > firmware to fail. Therefore, abandoning the approach of specifying > firmware in DTS. As an alternative, propose a static lookup table > mapping device compatible to firmware names. Currently, only WCN6855 > HW2.1 requires this. > > For details on usecase specific firmware, see: > https://lore.kernel.org/all/20250522013444.1301330-3-miaoqing.pan@oss.qualcomm.com/. > > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 > > Fixes: edbbc647c4f3 ("wifi: ath11k: support usercase-specific firmware overrides") > Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> > --- > drivers/net/wireless/ath/ath11k/core.c | 37 +++++++++++++++++++++++++- > drivers/net/wireless/ath/ath11k/core.h | 7 +++-- > 2 files changed, 39 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c > index 812686173ac8..a4a3a65c7752 100644 > --- a/drivers/net/wireless/ath/ath11k/core.c > +++ b/drivers/net/wireless/ath/ath11k/core.c > @@ -1,7 +1,6 @@ > // SPDX-License-Identifier: BSD-3-Clause-Clear > /* > * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. > - * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All rights reserved. > * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > */ > > @@ -997,6 +996,42 @@ static const struct dmi_system_id ath11k_pm_quirk_table[] = { > {} > }; > > +static const struct __ath11k_core_usecase_firmware_table { > + u32 hw_rev; > + const char *compatible; > + const char *firmware_name; > +} ath11k_core_usecase_firmware_table[] = { > + { ATH11K_HW_WCN6855_HW21, "qcom,lemans-evk", "nfa765"}, > + { ATH11K_HW_WCN6855_HW21, "qcom,monaco-evk", "nfa765"}, > + { ATH11K_HW_WCN6855_HW21, "qcom,hamoa-iot-evk", "nfa765"}, > + { /* Sentinel */ } > +}; > + > +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab) > +{ > + struct device_node *root __free(device_node) = of_find_node_by_path("/"); > + const struct __ath11k_core_usecase_firmware_table *entry = NULL; > + int i, count = of_property_count_strings(root, "compatible"); > + const char *compatible = NULL; > + > + for (i = 0; i < count; i++) { > + if (of_property_read_string_index(root, "compatible", i, > + &compatible) < 0) > + continue; > + > + entry = ath11k_core_usecase_firmware_table; > + while (entry->compatible) { > + if (ab->hw_rev == entry->hw_rev && > + !strcmp(entry->compatible, compatible)) > + return entry->firmware_name; > + entry++; > + } > + } > + > + return NULL; > +} > +EXPORT_SYMBOL(ath11k_core_get_usecase_firmware); > + > void ath11k_fw_stats_pdevs_free(struct list_head *head) > { > struct ath11k_fw_stats_pdev *i, *tmp; > diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h > index e8780b05ce11..f8fcd897ebd2 100644 > --- a/drivers/net/wireless/ath/ath11k/core.h > +++ b/drivers/net/wireless/ath/ath11k/core.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: BSD-3-Clause-Clear */ > /* > * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. > - * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > */ > > #ifndef ATH11K_CORE_H > @@ -1275,6 +1275,7 @@ bool ath11k_core_coldboot_cal_support(struct ath11k_base *ab); > > const struct firmware *ath11k_core_firmware_request(struct ath11k_base *ab, > const char *filename); > +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab); > > static inline const char *ath11k_scan_state_str(enum ath11k_scan_state state) > { > @@ -1325,9 +1326,7 @@ static inline void ath11k_core_create_firmware_path(struct ath11k_base *ab, > const char *filename, > void *buf, size_t buf_len) > { > - const char *fw_name = NULL; > - > - of_property_read_string(ab->dev->of_node, "firmware-name", &fw_name); > + const char *fw_name = ath11k_core_get_usecase_firmware(ab); > > if (fw_name && strncmp(filename, "board", 5)) > snprintf(buf, buf_len, "%s/%s/%s/%s", ATH11K_FW_DIR, Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible 2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan 2025-12-11 1:38 ` Baochen Qiang @ 2025-12-12 3:24 ` Krzysztof Kozlowski 1 sibling, 0 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2025-12-12 3:24 UTC (permalink / raw) To: Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 04/12/2025 08:10, Miaoqing Pan wrote: > @@ -1275,6 +1275,7 @@ bool ath11k_core_coldboot_cal_support(struct ath11k_base *ab); > > const struct firmware *ath11k_core_firmware_request(struct ath11k_base *ab, > const char *filename); > +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab); > > static inline const char *ath11k_scan_state_str(enum ath11k_scan_state state) > { > @@ -1325,9 +1326,7 @@ static inline void ath11k_core_create_firmware_path(struct ath11k_base *ab, > const char *filename, > void *buf, size_t buf_len) > { > - const char *fw_name = NULL; > - > - of_property_read_string(ab->dev->of_node, "firmware-name", &fw_name); > + const char *fw_name = ath11k_core_get_usecase_firmware(ab); NAK, silent ABI break without explanation.. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-04 7:10 [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan 2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan @ 2025-12-04 7:11 ` Miaoqing Pan 2025-12-09 19:56 ` Rob Herring (Arm) 2025-12-11 16:44 ` Jeff Johnson 1 sibling, 2 replies; 11+ messages in thread From: Miaoqing Pan @ 2025-12-04 7:11 UTC (permalink / raw) To: jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree, Miaoqing Pan The firmware-name property was introduced to allow end-users and integrators to select usecase specific firmware for the WCN6855. However, specifying firmware for an M.2 WLAN module in the Device Tree is not appropriate. Instead, this functionality will be handled within the ath11k driver. Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> --- .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml index e34d42a30192..0162e365798b 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml @@ -37,6 +37,7 @@ properties: firmware-name: maxItems: 1 + deprecated: true description: If present, a board or platform specific string used to lookup usecase-specific firmware files for the device. -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan @ 2025-12-09 19:56 ` Rob Herring (Arm) 2025-12-11 16:44 ` Jeff Johnson 1 sibling, 0 replies; 11+ messages in thread From: Rob Herring (Arm) @ 2025-12-09 19:56 UTC (permalink / raw) To: Miaoqing Pan Cc: linux-kernel, devicetree, conor+dt, krzk+dt, linux-wireless, ath11k, johannes, jjohnson On Thu, 04 Dec 2025 15:11:00 +0800, Miaoqing Pan wrote: > The firmware-name property was introduced to allow end-users and > integrators to select usecase specific firmware for the WCN6855. > However, specifying firmware for an M.2 WLAN module in the Device > Tree is not appropriate. Instead, this functionality will be handled > within the ath11k driver. > > Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> > --- > .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan 2025-12-09 19:56 ` Rob Herring (Arm) @ 2025-12-11 16:44 ` Jeff Johnson 2025-12-12 3:23 ` Krzysztof Kozlowski 2025-12-14 2:08 ` Miaoqing Pan 1 sibling, 2 replies; 11+ messages in thread From: Jeff Johnson @ 2025-12-11 16:44 UTC (permalink / raw) To: Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 12/3/2025 11:11 PM, Miaoqing Pan wrote: > The firmware-name property was introduced to allow end-users and > integrators to select usecase specific firmware for the WCN6855. > However, specifying firmware for an M.2 WLAN module in the Device > Tree is not appropriate. Instead, this functionality will be handled > within the ath11k driver. > > Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> > --- > .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > index e34d42a30192..0162e365798b 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > @@ -37,6 +37,7 @@ properties: > > firmware-name: > maxItems: 1 > + deprecated: true > description: > If present, a board or platform specific string used to lookup > usecase-specific firmware files for the device. The driver patch completely removes support for this, so is this really considered deprecated? Or should this actually be considered obsolete and completely removed? Do any DTS files actually reference this? /jeff ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-11 16:44 ` Jeff Johnson @ 2025-12-12 3:23 ` Krzysztof Kozlowski 2026-01-12 19:51 ` Jeff Johnson 2025-12-14 2:08 ` Miaoqing Pan 1 sibling, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2025-12-12 3:23 UTC (permalink / raw) To: Jeff Johnson, Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 11/12/2025 17:44, Jeff Johnson wrote: > On 12/3/2025 11:11 PM, Miaoqing Pan wrote: >> The firmware-name property was introduced to allow end-users and >> integrators to select usecase specific firmware for the WCN6855. >> However, specifying firmware for an M.2 WLAN module in the Device >> Tree is not appropriate. Instead, this functionality will be handled >> within the ath11k driver. >> >> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> index e34d42a30192..0162e365798b 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> @@ -37,6 +37,7 @@ properties: >> >> firmware-name: >> maxItems: 1 >> + deprecated: true >> description: >> If present, a board or platform specific string used to lookup >> usecase-specific firmware files for the device. > > The driver patch completely removes support for this, so is this really > considered deprecated? Or should this actually be considered obsolete and That's silent ABI break. I will formally NAK the patch. > completely removed? > > Do any DTS files actually reference this? > > /jeff Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-12 3:23 ` Krzysztof Kozlowski @ 2026-01-12 19:51 ` Jeff Johnson 2026-01-13 7:29 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: Jeff Johnson @ 2026-01-12 19:51 UTC (permalink / raw) To: Krzysztof Kozlowski, Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote: > On 11/12/2025 17:44, Jeff Johnson wrote: >> On 12/3/2025 11:11 PM, Miaoqing Pan wrote: >>> The firmware-name property was introduced to allow end-users and >>> integrators to select usecase specific firmware for the WCN6855. >>> However, specifying firmware for an M.2 WLAN module in the Device >>> Tree is not appropriate. Instead, this functionality will be handled >>> within the ath11k driver. >>> >>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> >>> --- >>> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>> index e34d42a30192..0162e365798b 100644 >>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>> @@ -37,6 +37,7 @@ properties: >>> >>> firmware-name: >>> maxItems: 1 >>> + deprecated: true >>> description: >>> If present, a board or platform specific string used to lookup >>> usecase-specific firmware files for the device. >> >> The driver patch completely removes support for this, so is this really >> considered deprecated? Or should this actually be considered obsolete and > > That's silent ABI break. I will formally NAK the patch. > > >> completely removed? >> >> Do any DTS files actually reference this? >> >> /jeff > > > Best regards, > Krzysztof Krzysztof, Can you check the v2 to see if you still want to NAK? https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com Thanks, /jeff ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2026-01-12 19:51 ` Jeff Johnson @ 2026-01-13 7:29 ` Krzysztof Kozlowski 0 siblings, 0 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2026-01-13 7:29 UTC (permalink / raw) To: Jeff Johnson, Miaoqing Pan, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 12/01/2026 20:51, Jeff Johnson wrote: > On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote: >> On 11/12/2025 17:44, Jeff Johnson wrote: >>> On 12/3/2025 11:11 PM, Miaoqing Pan wrote: >>>> The firmware-name property was introduced to allow end-users and >>>> integrators to select usecase specific firmware for the WCN6855. >>>> However, specifying firmware for an M.2 WLAN module in the Device >>>> Tree is not appropriate. Instead, this functionality will be handled >>>> within the ath11k driver. >>>> >>>> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> >>>> --- >>>> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>>> index e34d42a30192..0162e365798b 100644 >>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >>>> @@ -37,6 +37,7 @@ properties: >>>> >>>> firmware-name: >>>> maxItems: 1 >>>> + deprecated: true >>>> description: >>>> If present, a board or platform specific string used to lookup >>>> usecase-specific firmware files for the device. >>> >>> The driver patch completely removes support for this, so is this really >>> considered deprecated? Or should this actually be considered obsolete and >> >> That's silent ABI break. I will formally NAK the patch. >> >> >>> completely removed? >>> >>> Do any DTS files actually reference this? >>> >>> /jeff >> >> >> Best regards, >> Krzysztof > > Krzysztof, > Can you check the v2 to see if you still want to NAK? > > https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com > First, yes, still NAK. Second, that patch faked Rob's tag, so it is unacceptable! Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property 2025-12-11 16:44 ` Jeff Johnson 2025-12-12 3:23 ` Krzysztof Kozlowski @ 2025-12-14 2:08 ` Miaoqing Pan 1 sibling, 0 replies; 11+ messages in thread From: Miaoqing Pan @ 2025-12-14 2:08 UTC (permalink / raw) To: Jeff Johnson, jjohnson, johannes, robh, krzk+dt, conor+dt Cc: ath11k, linux-wireless, linux-kernel, devicetree On 12/12/2025 12:44 AM, Jeff Johnson wrote: > On 12/3/2025 11:11 PM, Miaoqing Pan wrote: >> The firmware-name property was introduced to allow end-users and >> integrators to select usecase specific firmware for the WCN6855. >> However, specifying firmware for an M.2 WLAN module in the Device >> Tree is not appropriate. Instead, this functionality will be handled >> within the ath11k driver. >> >> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> index e34d42a30192..0162e365798b 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> @@ -37,6 +37,7 @@ properties: >> >> firmware-name: >> maxItems: 1 >> + deprecated: true >> description: >> If present, a board or platform specific string used to lookup >> usecase-specific firmware files for the device. > > The driver patch completely removes support for this, so is this really > considered deprecated? Or should this actually be considered obsolete and > completely removed? > > Do any DTS files actually reference this? > > /jeff You are correct — since the driver has already removed all support for `firmware-name`, marking it as `deprecated` is misleading. The proper status should be `obsolete`, and the binding should reflect that this property is no longer supported. Regarding DTS usage: no upstream Device Tree files currently reference `firmware-name`. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-01-13 7:29 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-12-04 7:10 [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan 2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan 2025-12-11 1:38 ` Baochen Qiang 2025-12-12 3:24 ` Krzysztof Kozlowski 2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan 2025-12-09 19:56 ` Rob Herring (Arm) 2025-12-11 16:44 ` Jeff Johnson 2025-12-12 3:23 ` Krzysztof Kozlowski 2026-01-12 19:51 ` Jeff Johnson 2026-01-13 7:29 ` Krzysztof Kozlowski 2025-12-14 2:08 ` Miaoqing Pan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox