From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E176C433EF for ; Mon, 28 Mar 2022 19:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245671AbiC1TZ2 (ORCPT ); Mon, 28 Mar 2022 15:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239671AbiC1TZ1 (ORCPT ); Mon, 28 Mar 2022 15:25:27 -0400 Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C2F44C7B0; Mon, 28 Mar 2022 12:23:45 -0700 (PDT) Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B818960608; Mon, 28 Mar 2022 19:23:43 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA id 2E06A60009; Mon, 28 Mar 2022 19:23:42 +0000 (UTC) Message-ID: <683c72536c0672aa69c285ee505ec552fa76935f.camel@perches.com> Subject: Re: [PATCH 20/22 v2] ray_cs: Replace comments with C99 initializers From: Joe Perches To: Benjamin =?ISO-8859-1?Q?St=FCrz?= , Kalle Valo Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 28 Mar 2022 12:23:41 -0700 In-Reply-To: <1b694c4c-100b-951a-20f7-df1c912bb550@stuerz.xyz> References: <20220326165909.506926-20-benni@stuerz.xyz> <164846920750.11945.16978682699891961444.kvalo@kernel.org> <1b694c4c-100b-951a-20f7-df1c912bb550@stuerz.xyz> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: j6q6ks3ibsbnzi366ndy55ttbs79k55w X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 2E06A60009 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19IQarYsxSxQqbvpub87YW3Yy3ZsQhFYBU= X-HE-Tag: 1648495422-430544 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2022-03-28 at 20:21 +0200, Benjamin Stürz wrote: > Replace comments with C99's designated initializers. [] > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c [] > @@ -2529,20 +2529,23 @@ static void clear_interrupt(ray_dev_t *local) > #define MAXDATA (PAGE_SIZE - 80) > > static const char *card_status[] = { > - "Card inserted - uninitialized", /* 0 */ > - "Card not downloaded", /* 1 */ > - "Waiting for download parameters", /* 2 */ > - "Card doing acquisition", /* 3 */ > - "Acquisition complete", /* 4 */ > - "Authentication complete", /* 5 */ > - "Association complete", /* 6 */ > - "???", "???", "???", "???", /* 7 8 9 10 undefined */ > - "Card init error", /* 11 */ > - "Download parameters error", /* 12 */ > - "???", /* 13 */ > - "Acquisition failed", /* 14 */ > - "Authentication refused", /* 15 */ > - "Association failed" /* 16 */ > + [0] = "Card inserted - uninitialized", If you are going to do this at all, please use the #defines in drivers/net/wireless/rayctl.h [CARD_INSERTED] = "Card inserted - uninitialized", [CARD_AWAITING_PARAM] = "Card not downloaded", etc... $ git grep -w -P 'CARD_\w+' drivers/net/wireless/rayctl.h drivers/net/wireless/rayctl.h:#define CARD_INSERTED (0) drivers/net/wireless/rayctl.h:#define CARD_AWAITING_PARAM (1) drivers/net/wireless/rayctl.h:#define CARD_INIT_ERROR (11) drivers/net/wireless/rayctl.h:#define CARD_DL_PARAM (2) drivers/net/wireless/rayctl.h:#define CARD_DL_PARAM_ERROR (12) drivers/net/wireless/rayctl.h:#define CARD_DOING_ACQ (3) drivers/net/wireless/rayctl.h:#define CARD_ACQ_COMPLETE (4) drivers/net/wireless/rayctl.h:#define CARD_ACQ_FAILED (14) drivers/net/wireless/rayctl.h:#define CARD_AUTH_COMPLETE (5) drivers/net/wireless/rayctl.h:#define CARD_AUTH_REFUSED (15) drivers/net/wireless/rayctl.h:#define CARD_ASSOC_COMPLETE (6) drivers/net/wireless/rayctl.h:#define CARD_ASSOC_FAILED (16) > + [1] = "Card not downloaded", > + [2] = "Waiting for download parameters", > + [3] = "Card doing acquisition", > + [4] = "Acquisition complete", > + [5] = "Authentication complete", > + [6] = "Association complete", > + [7] = "???", > + [8] = "???", > + [9] = "???", > + [10] = "???", > + [11] = "Card init error", > + [12] = "Download parameters error", > + [13] = "???", > + [14] = "Acquisition failed", > + [15] = "Authentication refused", > + [16] = "Association failed" > }; > > static const char *nettype[] = { "Adhoc", "Infra " };