From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3158DC433B4 for ; Tue, 6 Apr 2021 18:29:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3B9A613B3 for ; Tue, 6 Apr 2021 18:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238509AbhDFSaA (ORCPT ); Tue, 6 Apr 2021 14:30:00 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:48396 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbhDFS34 (ORCPT ); Tue, 6 Apr 2021 14:29:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617733787; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=/Tpk/i5gAFjFHype6+eHyN/1UENfXc8j0unCtXTFneU=; b=FIj3qHv+nA8KSo6m+1DmnW6S3GVkiDypoSv7zhem1lUVsCRojMv4TeWrnW9eskncrDEjCyhy j1cYKgPZfKqmNjkbAyy/SsQeSgZHaKKGgyVqNYpsrg1aZQn0lrvk1i3THoeyJXKz37TORNrJ RfboF3Up5o8zUkesKEgeBGjnTwI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 606ca89bc06dd10a2d3cf308 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 06 Apr 2021 18:29:47 GMT Sender: gsamin=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C7BACC43464; Tue, 6 Apr 2021 18:29:46 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: gsamin) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3DE70C43461; Tue, 6 Apr 2021 18:29:46 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 06 Apr 2021 23:59:46 +0530 From: Govindaraj Saminathan To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH] mac80211: fix low throughput due to invalid addba extension In-Reply-To: <631e58cbfc146db2a6ca70ffc8b90648@codeaurora.org> References: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> <631e58cbfc146db2a6ca70ffc8b90648@codeaurora.org> Message-ID: <68a9d6b4eb7b77295f538f4aec3d8f84@codeaurora.org> X-Sender: gsamin@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-03-16 23:15, Govindaraj Saminathan wrote: > On 2021-03-16 21:21, Johannes Berg wrote: >> On Tue, 2021-03-16 at 21:17 +0530, Govindaraj wrote: >>> Addba request action frame received with the extension element from >>> certain 11ac stations, >>> >> >> Please indicate which so we have a record of who's shipping broken >> junk. The below log i taken with pixel3 client device >> >>> but the cmd id and length not matching to addba >>> extension and it failing in element parsing. >> >>> Due to this, addba request >>> not acknowledged and aggregation not started which is causing low >>> throughput. Hence validating the cmd id before processing addba >>> extension. >> >>>   ies_len = len - offsetof(struct ieee80211_mgmt, >>>   u.action.u.addba_req.variable); >>> - if (ies_len) { >>> + if (ies_len && >>> + mgmt->u.action.u.addba_req.variable[0] == WLAN_EID_ADDBA_EXT) { >>>   ieee802_11_parse_elems(mgmt->u.action.u.addba_req.variable, >>>                                  ies_len, true, &elems, mgmt->bssid, >>> NULL); >>>   if (elems.parse_error) >> >> So we get into parse_error without this? > yes, we getting parse error. >> >> What are they putting there instead? > first 9 bytes are addba request action frame and remaining 7 bytes > extension causing for parse error. > 03 00 01 02 10 00 00 e0 0a cf 08 06 11a 46 09 fe >> >> johannes