linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: vjakkam@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Enhance the AKM advertizement to support per interface.
Date: Fri, 17 Jan 2020 17:04:01 +0530	[thread overview]
Message-ID: <69277bd9d6abac200c2dcd931521d084@codeaurora.org> (raw)
In-Reply-To: <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net>

On 2020-01-02 19:11, Johannes Berg wrote:
> On Tue, 2019-12-24 at 00:22 +0530, Veerendranath Jakkam wrote:
>> 
>> @@ -2437,10 +2472,8 @@ static int nl80211_send_wiphy(struct 
>> cfg80211_registered_device *rdev,
>>  		state->split_start++;
>>  		break;
>>  	case 15:
>> -		if (rdev->wiphy.akm_suites &&
>> -		    nla_put(msg, NL80211_ATTR_AKM_SUITES,
>> -			    sizeof(u32) * rdev->wiphy.n_akm_suites,
>> -			    rdev->wiphy.akm_suites))
> 
> I don't think you should break this for all existing cases.
> 
> johannes

Thanks, I will correct in v2

  reply	other threads:[~2020-01-17 11:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23 18:52 [PATCH] cfg80211: Enhance the AKM advertizement to support per interface Veerendranath Jakkam
2020-01-02 13:41 ` Johannes Berg
2020-01-17 11:34   ` vjakkam [this message]
2020-01-02 13:45 ` Johannes Berg
2020-01-17 11:33   ` vjakkam
2020-01-17 11:35 ` [PATCH v2] " Veerendranath Jakkam
2020-01-20  8:57   ` Arend Van Spriel
2020-01-26 11:10     ` vjakkam
2020-01-26 11:21   ` [PATCH v3] " Veerendranath Jakkam
2020-01-26 17:32     ` Johannes Berg
2020-01-26 20:23       ` vjakkam
2020-01-26 20:30     ` [PATCH v4] " Veerendranath Jakkam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69277bd9d6abac200c2dcd931521d084@codeaurora.org \
    --to=vjakkam@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).