From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F7F2C33CB1 for ; Fri, 17 Jan 2020 11:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51C952082F for ; Fri, 17 Jan 2020 11:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Z+NBgOLz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbgAQLeH (ORCPT ); Fri, 17 Jan 2020 06:34:07 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:64702 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbgAQLeH (ORCPT ); Fri, 17 Jan 2020 06:34:07 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579260846; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=IVTvsdFHsyPS95Rjy+xQHtpW/tYPzQJL2Wcgi7Ip3QM=; b=Z+NBgOLz8TZPCIlL6WUlXeilZ3lmc3asW0jhtp0bAHApH65ZcoIWWUSdwljzTnM6rQWmDW/a 2GsepZtNR+se5mf9PlcxmRP42WbT/LGs0162Iopo4Tl8mnEuRlZBWZzRjH5SJzWhGObQQtwK 2afux9WcQDCsVnoNI5wl1M4LeVk= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e219ba9.7fe46906f730-smtp-out-n03; Fri, 17 Jan 2020 11:34:01 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 84B33C4479C; Fri, 17 Jan 2020 11:34:01 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: vjakkam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4E9CEC43383; Fri, 17 Jan 2020 11:34:01 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 17 Jan 2020 17:04:01 +0530 From: vjakkam@codeaurora.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: Enhance the AKM advertizement to support per interface. In-Reply-To: <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net> References: <20191223185255.1009-1-vjakkam@codeaurora.org> <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net> Message-ID: <69277bd9d6abac200c2dcd931521d084@codeaurora.org> X-Sender: vjakkam@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-01-02 19:11, Johannes Berg wrote: > On Tue, 2019-12-24 at 00:22 +0530, Veerendranath Jakkam wrote: >> >> @@ -2437,10 +2472,8 @@ static int nl80211_send_wiphy(struct >> cfg80211_registered_device *rdev, >> state->split_start++; >> break; >> case 15: >> - if (rdev->wiphy.akm_suites && >> - nla_put(msg, NL80211_ATTR_AKM_SUITES, >> - sizeof(u32) * rdev->wiphy.n_akm_suites, >> - rdev->wiphy.akm_suites)) > > I don't think you should break this for all existing cases. > > johannes Thanks, I will correct in v2