From: Johannes Berg <johannes@sipsolutions.net>
To: Cole Leavitt <cole@unwrap.rs>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: mld: stop mac80211 TX queues on firmware error
Date: Mon, 16 Feb 2026 12:29:46 +0100 [thread overview]
Message-ID: <692cd223edafb53133d35894d4ff7b3d0dbbf253.camel@sipsolutions.net> (raw)
In-Reply-To: <20260214060716.16394-1-cole@unwrap.rs>
On Fri, 2026-02-13 at 23:07 -0700, Cole Leavitt wrote:
> When firmware encounters an error in the iwlmld driver, nothing prevents
> mac80211 from continuing to feed TX packets. The mvm driver uses atomic
> status bits (IWL_MVM_STATUS_HW_RESTART_REQUESTED) checked in its TX path
> to gate transmissions, but the mld driver has no equivalent check --
> iwl_mld_tx_from_txq() only checks mld_txq->status.stop_full.
>
> This allows TX to proceed while firmware is unresponsive, causing
> spinlock contention and soft lockups lasting 22-26 seconds.
>
> Add ieee80211_stop_queues()
Using stop_queues()/wake_queues() seems a bit awkward, that API doesn't
interact all that well with the TXQ-based APIs that we use in this
driver. Shouldn't it just stop pulling from the TXQs in that case?
johannes
next prev parent reply other threads:[~2026-02-16 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 6:07 [PATCH] wifi: iwlwifi: mld: stop mac80211 TX queues on firmware error Cole Leavitt
2026-02-16 11:29 ` Johannes Berg [this message]
2026-02-18 14:17 ` [PATCH v2] wifi: iwlwifi: mld: skip TX when firmware is dead Cole Leavitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692cd223edafb53133d35894d4ff7b3d0dbbf253.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=cole@unwrap.rs \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox