From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:55131 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbZHPNQD convert rfc822-to-8bit (ORCPT ); Sun, 16 Aug 2009 09:16:03 -0400 Received: by fg-out-1718.google.com with SMTP id e12so277012fga.17 for ; Sun, 16 Aug 2009 06:16:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <43e72e890908151505s6cd9fea0p722de5a781a8ba8b@mail.gmail.com> References: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com> <1250281559-13041-11-git-send-email-lrodriguez@atheros.com> <69e28c910908150509i158bf2a6r33de5899cdc8bd13@mail.gmail.com> <43e72e890908151505s6cd9fea0p722de5a781a8ba8b@mail.gmail.com> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Sun, 16 Aug 2009 15:15:43 +0200 Message-ID: <69e28c910908160615r7bcb3966s9c09319f607f64b1@mail.gmail.com> Subject: Re: [PATCH v4 10/34] wireless: group Broadcom drivers on kconfig To: "Luis R. Rodriguez" Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net, Michael Buesch , Johannes Berg Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/8/16 Luis R. Rodriguez : > 2009/8/15 Gábor Stefanik : >> On Fri, Aug 14, 2009 at 10:25 PM, Luis R. >> Rodriguez wrote: >>> This moves Broadcom wireless drivers into their own menu. >>> There are only 2 Broadcom specific drivers so we group >>> them into a menu which can expand. Although rndis_wlan >>> also supports Broadcom devices, RNDIS is a spec and other >>> vendors could technically implement solutions with it >>> as well so we keep that separate as users most likely >>> won't look for those devices under a Broadcom tag. >>> >>> Cc: Michael Buesch >>> Cc: Gábor Stefanik >>> Cc: Johannes Berg >>> Signed-off-by: Luis R. Rodriguez >>> --- >>>  drivers/net/wireless/Kconfig |   13 +++++++++++++ >>>  1 files changed, 13 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig >>> index c2e88dc..150565d 100644 >>> --- a/drivers/net/wireless/Kconfig >>> +++ b/drivers/net/wireless/Kconfig >>> @@ -561,8 +561,21 @@ source "drivers/net/wireless/iwmc3200wifi/Kconfig" >>>  endif # INTEL_80211 >>> >>>  source "drivers/net/wireless/hostap/Kconfig" >>> + >>> +config BROADCOM_80211 >>> +       bool "Broadcom" >>> +       depends on WLAN_80211 >>> +       ---help--- >>> +         This will enable the support for Broadcom wireless drivers. This >>> +         includes b43 driver, b43legacy driver and the rndis_wlan driver. >> >> NAK. Again, rndis_wlan is Microsoft, not Broadcom. > > Yes, the patch does not group rndis with broadcom, please re-read the patch. > >  Luis > But it does say "This includes b43 driver, b43legacy driver and the rndis_wlan driver.", which is wrong. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)