From: Marek Vasut <marex@denx.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Adham Abozaeid" <adham.abozaeid@microchip.com>,
"Ajay Singh" <ajay.kathat@microchip.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Conor Dooley" <conor+dt@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string
Date: Sat, 24 Aug 2024 23:21:31 +0200 [thread overview]
Message-ID: <6a3d9171-3d5b-413d-bc48-cbc6ca10c48a@denx.de> (raw)
In-Reply-To: <facfaca2-e26e-4cab-9240-fdb0eac5c5fd@kernel.org>
On 8/24/24 8:22 AM, Krzysztof Kozlowski wrote:
Hi,
>> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> index 2460ccc082371..b8ee6cdab3c25 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> @@ -16,7 +16,11 @@ description:
>>
>> properties:
>> compatible:
>> - const: microchip,wilc1000
>> + oneOf:
>> + - items:
>> + - const: microchip,wilc1000
>> + - const: microchip,wilc3000
>
> That's wrong order of compatibles. Fallback is wilc1000, so should be
> the last item.
Right, fixed, thanks.
prev parent reply other threads:[~2024-08-24 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 16:08 [PATCH v2 1/4] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string Marek Vasut
2024-08-23 16:08 ` [PATCH v2 2/4] wifi: wilc1000: Fold wilc_get_chipid() into wlan.c Marek Vasut
2024-08-23 17:46 ` Simon Horman
2024-08-23 20:38 ` Marek Vasut
2024-08-24 12:44 ` Simon Horman
2024-08-24 21:18 ` Marek Vasut
2024-08-27 7:51 ` Alexis Lothoré
2024-08-27 15:34 ` Marek Vasut
2024-08-28 7:48 ` Alexis Lothoré
2024-08-23 16:08 ` [PATCH v2 3/4] wifi: wilc1000: Fold chip_allow_sleep()/chip_wakeup() " Marek Vasut
2024-08-27 8:14 ` Alexis Lothoré
2024-08-27 16:23 ` Marek Vasut
2024-08-23 16:08 ` [PATCH v2 4/4] wifi: wilc1000: Add WILC3000 support Marek Vasut
2024-08-27 8:28 ` Alexis Lothoré
2024-08-27 16:31 ` Marek Vasut
2024-08-24 6:22 ` [PATCH v2 1/4] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string Krzysztof Kozlowski
2024-08-24 21:21 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a3d9171-3d5b-413d-bc48-cbc6ca10c48a@denx.de \
--to=marex@denx.de \
--cc=adham.abozaeid@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox