Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Hao Tan <guwolf@guwolf.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: coex: Disable pre-AGC for out-of-band links
Date: Thu, 12 Nov 2026 01:54:18 +0000	[thread overview]
Message-ID: <6bcdf08684564b05b63ee446b42af5de@realtek.com> (raw)
In-Reply-To: <E6568F470624C07E+179429427543.116514.14355630958613033614@guwolf.com>

Hao Tan <guwolf@guwolf.com> wrote:
> When Wi-Fi and Bluetooth are on different RF bands, neither the TDD nor
> the FDD binding has a band. _update_coex_bind() records that as
> dm->out_of_band.
> 
> _set_wl_preagc_ctrl() disables pre-AGC when the TDD binding is 5 GHz, or
> when the role is still NOLINK. After commit a76501e1d148 ("wifi: rtw89:
> coex: Separate _ntfy_role_info into two function"), a 5 GHz-only STA is
> no longer NOLINK. With Wi-Fi on 5 GHz and Bluetooth on 2.4 GHz, tdd_bind
> is empty, so pre-AGC stays enabled. On RTL8851B this programs the
> pre-AGC table, and a VHT80 link drops shortly after association.
> 
> Also disable pre-AGC when dm->out_of_band is set. Overlapping TDD and
> FDD bindings are unchanged.
> 
> Tested on RTL8851BE (RFE 5, rtw8851b_fw-1.bin 0.29.41.5) with 5 GHz
> Wi-Fi and 2.4 GHz Bluetooth.

I'll keep above commit message, but remove below version info while
committing. 

> With this change, VHT80 stayed up for 600
> seconds on v7.3 and on rtw-next 04c998418722. Without it, v7.3 drops the
> link shortly after association.

> 
> Fixes: a76501e1d148 ("wifi: rtw89: coex: Separate _ntfy_role_info into two function")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/linux-wireless/340ed206ff6a4680a46806e3bea5dbc5@realtek.com/
> Signed-off-by: Hao Tan <guwolf@guwolf.com>

I'll pick this to rtw branch for -rc cycle.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>



  reply	other threads:[~2026-11-12  1:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 10:16 RTL8851BE: 5 GHz 80 MHz/HE beacon loss then auth timeout since 7.3 Tan Hao
2026-11-10  1:41 ` Ping-Ke Shih
2026-11-10  6:33   ` Hao Tan
2026-11-10  7:04     ` [PATCH] wifi: rtw89: coex: Disable pre-AGC for out-of-band links Hao Tan
2026-11-12  1:54       ` Ping-Ke Shih [this message]
2026-11-10  7:29     ` RTL8851BE: 5 GHz 80 MHz/HE beacon loss then auth timeout since 7.3 Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bcdf08684564b05b63ee446b42af5de@realtek.com \
    --to=pkshih@realtek.com \
    --cc=guwolf@guwolf.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox