From: Johannes Berg <johannes@sipsolutions.net>
To: Amith A <amith.a@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Subject: Re: [PATCH wireless-next v4 3/3] wifi: mac80211_hwsim: add incumbent signal interference detection support
Date: Tue, 10 Feb 2026 11:36:57 +0100 [thread overview]
Message-ID: <6c320ef1b8dc27cb70ec88ccbfb8add6b4d212cd.camel@sipsolutions.net> (raw)
In-Reply-To: <307b4098-8154-4d83-993d-88efe38426df@oss.qualcomm.com>
On Tue, 2026-02-10 at 16:06 +0530, Amith A wrote:
>
> > > +static int hwsim_write_simulate_incumbent_signal(void *dat, u64 val)
> > > +{
> > > + struct mac80211_hwsim_data *data = dat;
> > > + struct ieee80211_chanctx_conf *chanctx_conf = NULL;
> > > +
> > > + ieee80211_iter_chan_contexts_atomic(data->hw,
> > > + hwsim_6ghz_chanctx_iter,
> > > + &chanctx_conf);
> > > +
> > > + if (!chanctx_conf)
> > > + return -EINVAL;
> > Wouldn't it make more sense require userspace to write also the
> > frequency, rather than randomly picking the first 6 GHz chandef?
> Agree. I’m currently using DEFINE_DEBUGFS_ATTRIBUTE, which only supports
> a single u64 write. To accept both frequency and bitmap, is it okay if
> define a custom fops with a .write that parses two arguments?
Ah, right, 'u64 val'.
I guess you have no choice but to define a new operation, sure :-)
johannes
prev parent reply other threads:[~2026-02-10 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 11:21 [PATCH wireless-next v4 0/3] wifi: cfg80211/mac80211: add support to handle incumbent signal detected event Amith A
2026-02-05 11:21 ` [PATCH wireless-next v4 1/3] wifi: cfg80211: add support to handle incumbent signal detected event from mac80211/driver Amith A
2026-02-05 12:22 ` Johannes Berg
2026-02-10 10:31 ` Amith A
2026-02-05 11:21 ` [PATCH wireless-next v4 2/3] wifi: mac80211: add support to handle incumbent signal detected event from driver Amith A
2026-02-05 12:21 ` Johannes Berg
2026-02-10 10:33 ` Amith A
2026-02-05 11:21 ` [PATCH wireless-next v4 3/3] wifi: mac80211_hwsim: add incumbent signal interference detection support Amith A
2026-02-05 12:24 ` Johannes Berg
2026-02-10 10:36 ` Amith A
2026-02-10 10:36 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c320ef1b8dc27cb70ec88ccbfb8add6b4d212cd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=amith.a@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox