From: Felix Fietkau <nbd@nbd.name>
To: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com
Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
Deren.Wu@mediatek.com, km.lin@mediatek.com,
robin.chiu@mediatek.com, ch.yeh@mediatek.com,
posh.sun@mediatek.com, Eric.Liang@mediatek.com,
Stella.Chang@mediatek.com, jemele@google.com,
yenlinlai@google.com, linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: fix determining multicast frame in sta mode
Date: Fri, 13 Aug 2021 12:33:27 +0200 [thread overview]
Message-ID: <6c6ba2fd-3952-3c44-6c6d-51f77eb66828@nbd.name> (raw)
In-Reply-To: <fbc5d3da47b6a5e99ae255560279268f580e7b22.1628543190.git.objelf@gmail.com>
On 2021-08-09 23:13, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> We should use hdr->addr3 as the destination address to determine the frame
> is multicast frame or not when the device is running in sta mode.
>
> We can simply use ieee80211_get_DA for ap mode and sta mode both cases.
That does not make any sense to me. When a sta sends a packet with DA
set to a multicast address, it will be sent as unicast to the AP. Why
should it be treated as multicast by the driver?
- Felix
next prev parent reply other threads:[~2021-08-13 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 21:13 [PATCH] mt76: fix determining multicast frame in sta mode sean.wang
2021-08-13 10:33 ` Felix Fietkau [this message]
[not found] <6c6ba2fd-3952-3c44-6c6d-51f77eb66828@nbd.name--annotate>
2021-08-13 16:44 ` sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6ba2fd-3952-3c44-6c6d-51f77eb66828@nbd.name \
--to=nbd@nbd.name \
--cc=Deren.Wu@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Eric.Liang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=Stella.Chang@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=ch.yeh@mediatek.com \
--cc=jemele@google.com \
--cc=km.lin@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=yenlinlai@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox