RE: [PATCH rtw-next] wifi: rtw88: WARN only once in rtw_phy_get_tx_power_limit()

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> 
> On 09/02/2026 10:01, Ping-Ke Shih wrote:
> > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> >> This function WARNs when the wifi band, channel number, channel width,
> >> rate, or RF path are invalid. Two or three people have reported that it
> >> floods the kernel log with warnings because they try to switch to
> >> invalid channel numbers, like 130.
> >>
> >> One warning is probably enough, so turn WARN into WARN_ONCE.
> >>
> >> Closes: https://github.com/lwfinger/rtw88/issues/428
> >
> > As the issue says "invalid arguments, band=1, bw=2, path=1, rate=83, ch=130",
> > I think it operates on bandwidth 80MHz and primary channel 130.
> > But I don't see 20MHz primary channel, for example [1].
> >
> > Can we stop using this channel at set_channel() ahead to avoid this error?
> >
> > [1] https://en.wikipedia.org/wiki/List_of_WLAN_channels
> >
> 
> Is there a standard which says what channels are allowed?
> 
> Six weeks ago I asked people to test another patch which adds a check
> in rtw_set_channel() like you said, but no one replied. I guess I will
> send it as v2.

We are working on a patch to stop this kind of channels. I'd send a RFC
in coming week. 

> 
> By the way, there is another patch related to this problem:
> 
> https://lore.kernel.org/linux-wireless/20260306-rtw88_channel130-v1-1-ff25a5
> bc930a@igalia.com/
> 

I see.

Ping-Ke