From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.web.de ([212.227.15.14]:64978 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbdJ2UN5 (ORCPT ); Sun, 29 Oct 2017 16:13:57 -0400 Subject: [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template() From: SF Markus Elfring To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Arend Van Spriel , Eyal Reizer , Iain Hunter , James Minor , Johannes Berg , Kalle Valo , Maxim Altshul , Pieter-Paul Giesberts Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <6ea50cb4-8871-6752-6275-50da266f0e7d@users.sourceforge.net> (sfid-20171029_211415_651273_E0902081) Date: Sun, 29 Oct 2017 21:13:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Markus Elfring Date: Sun, 29 Oct 2017 20:00:41 +0100 Return directly after a call of the function "ieee80211_beacon_get" failed at the beginning. Signed-off-by: Markus Elfring --- drivers/net/wireless/ti/wlcore/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index efea811c1c83..0365b5e40a8d 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -4018,10 +4018,8 @@ static int wlcore_set_beacon_template(struct wl1271 *wl, struct sk_buff *beacon = ieee80211_beacon_get(wl->hw, vif); u16 tmpl_id; - if (!beacon) { - ret = -EINVAL; - goto out; - } + if (!beacon) + return -EINVAL; wl1271_debug(DEBUG_MASTER, "beacon updated"); -- 2.14.3