From: Johannes Berg <johannes@sipsolutions.net>
To: Pawel Dembicki <paweldembicki@gmail.com>, linux-wireless@vger.kernel.org
Cc: Antony Kolitsos <zeusomighty@hotmail.com>,
Roopni Devanathan <quic_rdevanat@quicinc.com>,
Thomas Fourier <fourier.thomas@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] wifi: mwl8k: inject DSSS Parameter Set element into beacons if missing
Date: Tue, 11 Nov 2025 10:23:53 +0100 [thread overview]
Message-ID: <6eeea6645b52d484a45b57086ea50bf5d8c34f86.camel@sipsolutions.net> (raw)
In-Reply-To: <20251111091708.2809266-2-paweldembicki@gmail.com>
> +static void mwl8k_beacon_copy_inject_ds_params(struct ieee80211_hw *hw,
> + u8 *buf_dst, const u8 *buf_src,
> + int src_len)
> +{
> + const struct ieee80211_mgmt *mgmt = (const void *)buf_src;
> + static const u8 before_ds_params[] = {
> + WLAN_EID_SSID,
> + WLAN_EID_SUPP_RATES,
> + };
Heh, I meant you should have only one tab to indent the constants, not
indent the clsoing brace, but I guess I can fix that.
Should this go to wireless? Maybe then a Fixes tag would be nice?
johannes
prev parent reply other threads:[~2025-11-11 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 9:17 [PATCH v3] wifi: mwl8k: inject DSSS Parameter Set element into beacons if missing Pawel Dembicki
2025-11-11 9:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eeea6645b52d484a45b57086ea50bf5d8c34f86.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fourier.thomas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=paweldembicki@gmail.com \
--cc=quic_rdevanat@quicinc.com \
--cc=zeusomighty@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox