From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D293EB64D8 for ; Wed, 14 Jun 2023 18:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233922AbjFNScz (ORCPT ); Wed, 14 Jun 2023 14:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbjFNScy (ORCPT ); Wed, 14 Jun 2023 14:32:54 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B6F1BF9 for ; Wed, 14 Jun 2023 11:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=VIVempwRAnUTae1kulh+NMBkImnt8hqihQQr0dy+2EM=; t=1686767572; x=1687977172; b=G1y98azXTSd36fgzZwyp7fMRwfK3oNOZbCLCUl6HG++FOrw P2AlhbmyLEtY6EBaTYA9BpOlr9Y7/4iM5qg9sXfcwwQ+BtovLCgztPM/0JR/YSDiHoTQKXuvnA6gr RSz18DeI9Kl2XMXJ1SYOZPzvt8uUYHQb1h/BhqUDgcWTz3owJZ9GCkKGknNsuy/FR8niVY9uT1H4/ uoSCCNdxEDxBczGjMYU18Eg18Dh/B/X7mu59by0aqCQMZbX9jAx/8rcRW2y9SQ3evrz4ClUawjx2n naIrWE7nzz9T/lJWUZA3UfB42i+28DG4i+5FEV49FtXoA1U+mjId7NNK0morIiVA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q9VIX-006Ix5-00; Wed, 14 Jun 2023 20:32:49 +0200 Message-ID: <6f8db032286923845202c7d658f1d39db79a758c.camel@sipsolutions.net> Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links From: Johannes Berg To: Wen Gong , linux-wireless@vger.kernel.org Cc: ath11k@lists.infradead.org Date: Wed, 14 Jun 2023 20:32:48 +0200 In-Reply-To: <1c26c205-0240-7670-117d-02a7af068724@quicinc.com> References: <20220902141259.377789-1-johannes@sipsolutions.net> <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid> <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com> <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net> <113761966918b2f390d3c9304307b42a0b4a829b.camel@sipsolutions.net> <76863dec-1b2f-b933-7c5e-21c732de4bc6@quicinc.com> <2cc79101249548f2a92c14af6aff6121143907d6.camel@sipsolutions.net> <1c26c205-0240-7670-117d-02a7af068724@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2023-05-24 at 15:41 +0800, Wen Gong wrote: >=20 > May I add a new ops in struct ieee80211_ops? like this: >=20 > u16 active_links(struct ieee80211_hw *hw, struct ieee80211_vif vif, u16= =20 > new_links)" >=20 > then ieee80211_set_vif_links_bitmaps() call the ops to get the links for= =20 > station and set the sdata->vif.active_links with the return value from= =20 > lower driver, > it means lower driver will dynamic select the links count at this moment. >=20 > If lower driver not register ops active_links, then keep current logic. >=20 I guess you can can send patches for whatever you want :) But I have no idea what you're trying to do? Why would you need to have a callback? Was this for link selection in the driver? We should have a patch somewhere that adds a BSS_CHANGE flag for when the valid links change, so the driver can select others. johannes