Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

[Heiner Kallweit <hkallweit1@gmail.com>]

Am 13.05.2017 um 14:35 schrieb Hans de Goede:
> <resend with the author of the commit causing this added>
> 
> Hi,
> 
> On 13-05-17 14:19, Hans de Goede wrote:
>> Hi,
>>
>> I've just rebased my personal kernel tree to what will soon be 4.12-rc1
>> and I'm getting my dmesg log filled with the following errors:
>>
>> [   32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8
>> [   32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8
>> [   33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8
>>
After a brief look at the code I'm not sure that the check actually checks
for an error condition. Apart from the error messages:
Do you face issues with the functionality of the driver?

>> Other brcmfmac dmesg messages:
>>
>> [   16.020013] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634
>>
>> This is on a Asus T100TA which uses a 43241b1
> 
> Ok, this seems to be a regression caused by:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e84ab604bded
> "brcmfmac: properly align buffers on certain platforms with 64 bit DMA"
> 
> I believe this may need a different fix then that.
> 
> Regards,
> 
> Hans
>