From: Ping-Ke Shih <pkshih@realtek.com>
To: Zhao Li <enderaoelyther@gmail.com>
Cc: Bernie Huang <phhuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v2] wifi: rtw89: update PN state only from correctly decrypted frames
Date: Mon, 16 Nov 2026 09:25:32 +0000 [thread overview]
Message-ID: <7040b729e3a04d3a953bfdc4fd8ab416@realtek.com> (raw)
In-Reply-To: <20261116092300.20414-1-enderaoelyther@gmail.com>
Zhao Li <enderaoelyther@gmail.com> wrote:
> rtw89_core_skb_pn_valid() records the sequence and packet numbers of
> hardware-decrypted QoS data frames so that it can drop frames whose
> sequence number goes backwards while the PN advances. It runs before
> mac80211 discards frames with an ICV/MIC or FCS error and requires only
> hw_dec, so a frame that failed decryption still updates last_sn and
> last_pn. Such a frame need not come from the peer. One with an advanced
> sequence number and a PN between the recorded PN and the peer's next
> one makes the check drop the peer's following valid frames until their
> sequence numbers catch up.
>
> Skip frames that rtw89_core_update_rx_status() does not report to
> mac80211 as decrypted, or reports with an FCS error.
>
> Found by code review and not reproduced; compile-tested only.
>
> AI assistance was used.
>
> Fixes: bda294ed0ed0 ("wifi: rtw89: Drop malformed AMPDU frames with abnormal PN")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhao Li <enderaoelyther@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
prev parent reply other threads:[~2026-11-16 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 9:23 [PATCH rtw-next v2] wifi: rtw89: update PN state only from correctly decrypted frames Zhao Li
2026-11-16 9:25 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7040b729e3a04d3a953bfdc4fd8ab416@realtek.com \
--to=pkshih@realtek.com \
--cc=enderaoelyther@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox